Skip to content

add missing orca dependency for NanoPlot#11967

Merged
verdurin merged 1 commit intoeasybuilders:developfrom
boegel:20210107195508_new_pr_NanoPlot1284
Jan 8, 2021
Merged

add missing orca dependency for NanoPlot#11967
verdurin merged 1 commit intoeasybuilders:developfrom
boegel:20210107195508_new_pr_NanoPlot1284

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jan 7, 2021

(created using eb --new-pr)
orca is required by NanoPlot to export figures as static images

@boegel boegel added this to the next release (4.3.3?) milestone Jan 7, 2021
@boegel boegel added the bug fix label Jan 7, 2021
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jan 7, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 7, 2021

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11967 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11967 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12390

Test results coming soon (I hope)...

Details

- notification for comment with ID 756313707 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 7, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-x-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/8afcda8b4e8241f2cd1fe04ed09499ef for a full test report.

@boegel boegel requested a review from verdurin January 7, 2021 19:24
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jan 7, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2630.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/d369193206f661af6739656a58eb11e4 for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jan 8, 2021

@boegel we don't have intel/2019b currently.

verdurin
verdurin approved these changes Jan 8, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jan 8, 2021

Going in, thanks @boegel!

@verdurin verdurin merged commit f412090 into easybuilders:develop Jan 8, 2021
@boegel boegel deleted the 20210107195508_new_pr_NanoPlot1284 branch January 8, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@verdurin verdurin verdurin approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.3.3

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @verdurin