Skip to content

rename orca to plotly-orca#12015

Merged
verdurin merged 3 commits intoeasybuilders:developfrom
lexming:plotly-orca
Jan 29, 2021
Merged

rename orca to plotly-orca#12015
verdurin merged 3 commits intoeasybuilders:developfrom
lexming:plotly-orca

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented Jan 17, 2021

Rename the orca package to plotly-orca to avoid confusion with ORCA.

@lexming lexming added the change label Jan 17, 2021
@lexming lexming added this to the next release (4.3.3?) milestone Jan 17, 2021
@lexming lexming mentioned this pull request Jan 17, 2021
Merged
@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Jan 18, 2021

Test report by @lexming
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
node381.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/450133afedcd2956623ff9ef277ef705 for a full test report.

@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Jan 26, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 26, 2021

@migueldiascosta: Request for testing this PR well received on generoso

PR test command 'EB_PR=12015 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12015 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13701

Test results coming soon (I hope)...

Details

- notification for comment with ID 767285528 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 26, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 13 out of 13 (6 easyconfigs in total)
generoso-x-5 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/e6e182e3396997b07ae2629415a0dac5 for a full test report.

@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Jan 27, 2021

lgtm - @boegel, any objections?

verdurin
verdurin approved these changes Jan 29, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jan 29, 2021

Going in, thanks @lexming!

@verdurin verdurin merged commit 816ae64 into easybuilders:develop Jan 29, 2021
@lexming lexming deleted the plotly-orca branch January 30, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@verdurin verdurin verdurin approved these changes

Assignees

No one assigned

Labels

change

Projects

None yet

Milestone

4.3.3

Development

Successfully merging this pull request may close these issues.

4 participants

@lexming @migueldiascosta @boegelbot @verdurin