Skip to content

{tools}[foss/2018b,gompi/2019b,foss/2019b] remove Python from ecCodes v2.17.0 and add ecCodes v2.15.0 with eccodes-python v1.0.0#12084

Merged
smoors merged 5 commits intoeasybuilders:developfrom
lexming:20210201232845_new_pr_ecCodes2170
Feb 4, 2021
Merged

{tools}[foss/2018b,gompi/2019b,foss/2019b] remove Python from ecCodes v2.17.0 and add ecCodes v2.15.0 with eccodes-python v1.0.0#12084
smoors merged 5 commits intoeasybuilders:developfrom
lexming:20210201232845_new_pr_ecCodes2170

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented Feb 1, 2021 •
edited
Loading

(created using eb --new-pr)

Since version 2.13.0 of ecCodes the bindings to Python 3 are not provided by the main package and instead they were moved to eccodes-python. Therefore, the easyconfigs ecCodes-2.17.0-foss-2018b-Python-3.6.6.eb and ecCodes-2.17.0-foss-2019b-Python-3.7.4.eb are not working as intended and they do not provide any binding to Python 3. In fact, those builds are equivalent to any build of ecCodes without Python.

This PR fixes this issue by removing the dependency on Python to those easyconfigs and adding respective easyconfgis for eccodes-python with the missing bindings to Python 3.
This PR fixes this issue by

  • removing the dependency on Python to those easyconfigs of ecCodes v2.17.0 (the resulting build is equivalent)
  • adding ecCodes v2.15.0 in gompi/2019b and eccodes-python v1.0.0 in foss/2019b to provide bindings with Python 3.7.4 (similar to ecCodes-2.17.0-foss-2019b-Python-3.7.4.eb)
  • there is no way to provide bindings with Python 3.6.6 in foss/2018b with eccodes-python due to version restrictions in EB, so those cannot be added

I'm also making the fixes described in #12081 to these easyconfigs of ecCodes.

@lexming lexming added the update label Feb 1, 2021
@lexming
adding easyconfigs: eccodes-python-1.0.0-foss-2018b-Python-3.6.6.eb, …
86bc44d 
…eccodes-python-1.0.0-foss-2019b-Python-3.7.4.eb
@lexming lexming added the bug fix label Feb 1, 2021
@lexming lexming changed the title remove dependency on Python in easyconfigs for ecCodes v2.17.0 {tools}[foss/2018b,gompi/2019b,foss/2019b] fix Python bindings on ecCodes v2.17.0 with eccodes-python v1.0.0 Feb 1, 2021
@lexming lexming changed the title {tools}[foss/2018b,gompi/2019b,foss/2019b] fix Python bindings on ecCodes v2.17.0 with eccodes-python v1.0.0 {tools}[foss/2018b,gompi/2019b,foss/2019b] remove Python from ecCodes v2.17.0 and add ecCodes v2.15.0 with eccodes-python v1.0.0 Feb 1, 2021
@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Feb 1, 2021

Test report by @lexming
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
node375.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/08b81851c9e50062d2a5a792d9f8c4b3 for a full test report.

edmondac added a commit to bear-rsg/easybuild-easyconfigs that referenced this pull request Feb 3, 2021
@edmondac
Don't need python versionsuffix any more, see easybuilders#12084
23d7f27
smoors
smoors previously requested changes Feb 3, 2021
View reviewed changes
Comment thread easybuild/easyconfigs/e/ecCodes/ecCodes-2.17.0-gompi-2019b.eb
smoors
smoors reviewed Feb 4, 2021
View reviewed changes
Comment thread easybuild/easyconfigs/e/ecCodes/ecCodes-2.15.0-gompi-2019b.eb

configopts = "-DENABLE_NETCDF=ON -DENABLE_PNG=ON -DENABLE_PYTHON=OFF "
configopts += "-DENABLE_JPG=ON -DENABLE_JPG_LIBJASPER=ON "
configopts += "-DENABLE_ECCODES_THREADS=ON" # multi-threading with pthreads
Copy link
Copy Markdown
Contributor

@smoors smoors Feb 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any specific reason why you did not use ENABLE_ECCODES_OMP_THREADS here?

Copy link
Copy Markdown
Contributor Author

@lexming lexming Feb 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing else than I never tested it in this older versions, I arbitrarily started with pthreads until recent versions (~2.18.0) where it started to cause issues at link time and I switched to openmp. So it might work or it might not.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Feb 4, 2021

Test report by @smoors
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
node381.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 2.7.5
See https://gist.github.com/31f416b869c4641f39dec829d211981d for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Feb 4, 2021

@boegelbot: please test @ generoso

@smoors smoors dismissed their stale review February 4, 2021 19:28

not applicable

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 4, 2021

@smoors: Request for testing this PR well received on generoso

PR test command 'EB_PR=12084 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12084 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13780

Test results coming soon (I hope)...

Details

- notification for comment with ID 773549616 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 4, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/d9ccac967ba5eb2036b2f42fead032bd for a full test report.

@smoors smoors added this to the next release (4.3.3?) milestone Feb 4, 2021
smoors
smoors approved these changes Feb 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Feb 4, 2021

Going in, thanks @lexming!

@smoors smoors merged commit 49f6638 into easybuilders:develop Feb 4, 2021
@lexming lexming deleted the 20210201232845_new_pr_ecCodes2170 branch February 5, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

bug fix update

Projects

None yet

Milestone

4.3.3

Development

Successfully merging this pull request may close these issues.

3 participants

@lexming @smoors @boegelbot