Skip to content

{numlib}[GCC/10.2.0] BLIS v0.8.0, add missing Perl build dependency#12146

Merged
boegel merged 3 commits intoeasybuilders:developfrom
akesandgren:20210212112738_new_pr_BLIS080
Feb 12, 2021
Merged

{numlib}[GCC/10.2.0] BLIS v0.8.0, add missing Perl build dependency#12146
boegel merged 3 commits intoeasybuilders:developfrom
akesandgren:20210212112738_new_pr_BLIS080

Conversation

@akesandgren
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren commented Feb 12, 2021 •
edited
Loading

(created using eb --new-pr)

Fixes #12145

@akesandgren akesandgren added this to the next release (4.3.3?) milestone Feb 12, 2021
@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented Feb 12, 2021

Test report by @akesandgren
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
b-an02.hpc2n.umu.se - Linux ubuntu 16.04, x86_64, Intel(R) Xeon(R) CPU E5-2690 v4 @ 2.60GHz, Python 2.7.12
See https://gist.github.com/ea3cddc7972dcf9fabd9269e0e079ef0 for a full test report.

boegel
boegel requested changes Feb 12, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akesandgren Please apply same fix to BLIS-0.8.0-GCC-9.3.0.eb too...

eidt: fixed it myself in c03f6e7

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 12, 2021

@boegelbot please test @ generoso

@boegel boegel force-pushed the 20210212112738_new_pr_BLIS080 branch from 28f9be4 to c03f6e7 Compare February 12, 2021 12:40
@easybuilders easybuilders deleted a comment from boegelbot Feb 12, 2021
@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented Feb 12, 2021

Good thing I didn't see your "fixed it myself" since that was incorrect...

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 12, 2021

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12146 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12146 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13807

Test results coming soon (I hope)...

Details

- notification for comment with ID 778171980 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 12, 2021

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3107.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/a85211337f62c39569ec3fc017a7fabc for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 12, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
generoso-x-3 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/98b79b5cbfa94c7dcefb7afbefeedc15 for a full test report.

@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented Feb 12, 2021

Test report by @akesandgren
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
b-an02.hpc2n.umu.se - Linux ubuntu 16.04, x86_64, Intel(R) Xeon(R) CPU E5-2690 v4 @ 2.60GHz, Python 2.7.12
See https://gist.github.com/adf73937aed16955a05168a7bc74b063 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 12, 2021

Going in, thanks @akesandgren!

@boegel boegel merged commit b5734da into easybuilders:develop Feb 12, 2021
@akesandgren akesandgren deleted the 20210212112738_new_pr_BLIS080 branch February 12, 2021 12:53
@boegel boegel changed the title {numlib}[GCC/10.2.0] BLIS v0.8.0, fix missing Perl dep. {numlib}[GCC/10.2.0] BLIS v0.8.0, add missing Perl build dependency Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.3.3

Development

Successfully merging this pull request may close these issues.

BLIS depends on Perl during configure

3 participants

@akesandgren @boegel @boegelbot