Skip to content

Correct the GCC version check to allow IBM VSX builds of GROMACS 2020.4 and 2020.5#12159

Merged
boegel merged 2 commits intoeasybuilders:developfrom
branfosj:20210215100451_new_pr_GROMACS20204
Feb 15, 2021
Merged

Correct the GCC version check to allow IBM VSX builds of GROMACS 2020.4 and 2020.5#12159
boegel merged 2 commits intoeasybuilders:developfrom
branfosj:20210215100451_new_pr_GROMACS20204

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Feb 15, 2021 •
edited
Loading

(created using eb --new-pr)

GROMACS added a check in 2020.2 to stop IBM VSX builds with GCC > 9 (https://redmine.gromacs.org/projects/gromacs/repository/revisions/60a138c51ab4bcec063cb78dea55fafceca07e9a). The check was meant to be GCC >= 10 (https://redmine.gromacs.org/projects/gromacs/repository/revisions/9baf5dcc540878dc0b15d8b945ac760d36fbf75d/diff). This corrects the issue on 2020.4 and 2020.5.

This also adds the disable hwloc test patch to 2020.4.

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Feb 15, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 15, 2021

@branfosj: Request for testing this PR well received on generoso

PR test command 'EB_PR=12159 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12159 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13819

Test results coming soon (I hope)...

Details

- notification for comment with ID 779124717 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel boegel added this to the next release (4.3.3?) milestone Feb 15, 2021
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Feb 15, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0305u15a.bear.cluster - Linux RHEL 8.2, POWER, 8335-GTX (power9le), Python 3.6.8
See https://gist.github.com/b51acf2f09e3862d40204a033becf07a for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 15, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
generoso-x-3 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/b9f8319f1f9c6aea5b65bbd62030613b for a full test report.

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Feb 15, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0212u17a.bear.cluster - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2640 v4 @ 2.40GHz (broadwell), Python 3.6.8
See https://gist.github.com/675a4e9ae2e1a709764ce1db84848103 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 15, 2021

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3518.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/8d55dd383fac3fb5a93e5932c92b985e for a full test report.

@boegel boegel enabled auto-merge February 15, 2021 14:28
boegel
boegel approved these changes Feb 15, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 131a4ba into easybuilders:develop Feb 15, 2021
@branfosj branfosj deleted the 20210215100451_new_pr_GROMACS20204 branch February 15, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.3.3

Development

Successfully merging this pull request may close these issues.

3 participants

@branfosj @boegelbot @boegel