Adding missing GNU time dependency to WRF 4.0.2 built with foss/2018b by dithwick · Pull Request #12179 · easybuilders/easybuild-easyconfigs

dithwick · 2021-02-17T09:31:44Z

(created using eb --new-pr)

…suffix to top.

branfosj

lgtm

branfosj · 2021-02-17T15:06:43Z

@boegelbot please test @ generoso

boegelbot · 2021-02-17T15:10:19Z

@branfosj: Request for testing this PR well received on generoso

PR test command 'EB_PR=12179 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12179 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 13859

Test results coming soon (I hope)...

Details

- notification for comment with ID 780619161 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2021-02-17T15:20:38Z

Test report by @boegelbot
FAILED
Build succeeded for 3 out of 4 (2 easyconfigs in total)
generoso-x-3 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/8a7c2f7f0d2fe21b4e8a2bbd3db98a80 for a full test report.

dismiss review as there is a build failure to debug

branfosj · 2021-02-17T16:18:06Z

Failure seems to be (unless there was one higher in the log - before the bit we can see):

fatal error: rpc/types.h: No such file or directory

This suggests needing a dependency on https://github.com/easybuilders/easybuild-easyconfigs/blob/develop/easybuild/easyconfigs/l/libtirpc/libtirpc-1.1.4-GCCcore-7.3.0.eb

I'm currently running a test on CentOS 8 to see if I can confirm.

dithwick · 2021-02-17T16:20:03Z

Thanks @branfosj

boegel · 2021-02-17T19:06:51Z

@branfosj See also #11496 (comment)

dithwick · 2021-02-18T12:24:41Z

I'll see if the patch with #11496 (comment) works first, if not I'll create one. I'll need someone to test on CentOS 8 though.

boegel · 2021-02-19T17:30:53Z

@boegelbot please test @ generoso

boegelbot · 2021-02-19T17:35:11Z

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12179 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12179 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 13883

Test results coming soon (I hope)...

Details

- notification for comment with ID 782222398 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegel · 2021-02-19T17:37:30Z

Test report by @boegel
FAILED
Build succeeded for 4 out of 5 (2 easyconfigs in total)
node3600.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/eb72a0f855e2cbc83c881d6832d964a9 for a full test report.

boegelbot · 2021-02-19T17:44:58Z

Test report by @boegelbot
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in total)
generoso-c1-s-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/70357ea746fd93646cdd7b93b986500b for a full test report.

boegel · 2021-02-19T20:25:06Z

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node2609.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/017448ce0298cee537bb5fcfad8adf26 for a full test report.

dithwick · 2021-02-22T15:42:07Z

Hopefully this will work. Also flagging wrf-model/WRF#1072 for reference.

branfosj · 2021-02-23T07:36:05Z

@boegelbot please test @ generoso

boegelbot · 2021-02-23T07:40:07Z

@branfosj: Request for testing this PR well received on generoso

PR test command 'EB_PR=12179 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12179 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 16188

Test results coming soon (I hope)...

Details

- notification for comment with ID 783976156 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2021-02-23T10:48:20Z

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/680098cec52ebdd5d5f2d7c954c1374d for a full test report.

branfosj · 2021-02-23T14:04:55Z

Test report by @branfosj
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/f6d13ecda2bec5c8b07b6826daadd7db for a full test report.

branfosj

lgtm

branfosj · 2021-02-26T19:10:49Z

Going in, thanks @dithwick!

boegel · 2021-02-26T20:50:45Z

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node2719.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/9cdfdb865b7dc18b485f6d292da534a9 for a full test report.

Adding missing GNU time dependency to WRF and moved buildtype/version…

bfcf807

…suffix to top.

branfosj added bug fix update labels Feb 17, 2021

branfosj added this to the next release (4.3.3?) milestone Feb 17, 2021

branfosj previously approved these changes Feb 17, 2021

View reviewed changes

Added patch to link against libtirpc for CentOS 8.

52a8bb9

boegel modified the milestones: next release (4.3.3?), release after 4.3.3 Feb 19, 2021

Added CPATH fix to libtirpc.

85f803a

boegel changed the title ~~Adding missing GNU time dependency to WRF and moved buildtype/versionsuffix to top.~~ Adding missing GNU time dependency to WRF 4.0.2 built with foss/2018b Feb 26, 2021

branfosj approved these changes Feb 26, 2021

View reviewed changes

branfosj merged commit 63bde85 into easybuilders:develop Feb 26, 2021

dithwick deleted the 20210217093130_new_pr_time19 branch March 1, 2021 08:40

Conversation

dithwick commented Feb 17, 2021

Uh oh!

branfosj left a comment

Choose a reason for hiding this comment

Uh oh!

branfosj commented Feb 17, 2021

Uh oh!

boegelbot commented Feb 17, 2021

Uh oh!

boegelbot commented Feb 17, 2021

Uh oh!

branfosj commented Feb 17, 2021

Uh oh!

dithwick commented Feb 17, 2021

Uh oh!

boegel commented Feb 17, 2021

Uh oh!

dithwick commented Feb 18, 2021

Uh oh!

boegel commented Feb 19, 2021

Uh oh!

boegelbot commented Feb 19, 2021

Uh oh!

boegel commented Feb 19, 2021

Uh oh!

boegelbot commented Feb 19, 2021

Uh oh!

boegel commented Feb 19, 2021

Uh oh!

dithwick commented Feb 22, 2021

Uh oh!

branfosj commented Feb 23, 2021

Uh oh!

boegelbot commented Feb 23, 2021

Uh oh!

boegelbot commented Feb 23, 2021

Uh oh!

branfosj commented Feb 23, 2021

Uh oh!

branfosj left a comment

Choose a reason for hiding this comment

Uh oh!

branfosj commented Feb 26, 2021

Uh oh!

boegel commented Feb 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants