Skip to content

fix build of Bison using older GCC#12203

Merged
boegel merged 2 commits intoeasybuilders:developfrom
branfosj:20210219083506_new_pr_Bison353
Feb 19, 2021
Merged

fix build of Bison using older GCC#12203
boegel merged 2 commits intoeasybuilders:developfrom
branfosj:20210219083506_new_pr_Bison353

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Feb 19, 2021

(created using eb --new-pr)

fixes #12202

I do not have a sufficiently old GCC to be able to test this fixes the issue.

@branfosj

This comment has been minimized.

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@branfosj It doesn't make sense to use this patch for Bison-3.5.3-GCCcore-9.3.0.eb, but patching Bison-3.5.3.eb does make sense?

@boegel boegel modified the milestones: 4.x, next release (4.3.3?) Feb 19, 2021
@branfosj
Copy link
Copy Markdown
Member Author

@branfosj It doesn't make sense to use this patch for Bison-3.5.3-GCCcore-9.3.0.eb, but patching Bison-3.5.3.eb does make sense?

Fixed in c3ba286

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 19, 2021

@boegelbot please test @ generoso

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 19, 2021

I tested (manually) building Bison 3.5.3 in an old SL6 Singularity container, fails without the patch as reported in #12202, works with the patch:

Singularity> bison --version
bison (GNU Bison) 3.5.3

Singularity> cat /etc/redhat-release
Scientific Linux release 6.9 (Carbon)

Singularity> gcc --version
gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-18)

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12203 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12203 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13879

Test results coming soon (I hope)...

Details

- notification for comment with ID 781976768 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@branfosj
Copy link
Copy Markdown
Member Author

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/d32ad9179ce162951cc41fb4a4ec4c10 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-x-3 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/7ca78c9df5fa1c591d7d33e174a3b95a for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 19, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3101.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/02c40970aff8592a6ee4e53c4de3474d for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 19, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3503.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/f5298aea2361a9875de5f17cb968e637 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 19, 2021

Going in, thanks @branfosj!

@boegel boegel merged commit 265bf71 into easybuilders:develop Feb 19, 2021
@branfosj branfosj deleted the 20210219083506_new_pr_Bison353 branch February 19, 2021 10:36
@branfosj
Copy link
Copy Markdown
Member Author

Test report by @branfosj
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/94764ca6baaa231a73a128baa4ef1d28 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bison 3.5.3 fails to install with older GCC

3 participants