Skip to content

add missing build dependency on pkg-config to VCFtools 0.1.16#12245

Merged
lexming merged 5 commits intoeasybuilders:developfrom
fizwit:20210222195314_new_pr_VCFtools0116
Mar 3, 2021
Merged

add missing build dependency on pkg-config to VCFtools 0.1.16#12245
lexming merged 5 commits intoeasybuilders:developfrom
fizwit:20210222195314_new_pr_VCFtools0116

Conversation

@fizwit
Copy link
Copy Markdown
Contributor

@fizwit fizwit commented Feb 23, 2021

(created using eb --new-pr)

Micket
Micket previously requested changes Feb 24, 2021
View reviewed changes
Comment thread easybuild/easyconfigs/v/VCFtools/VCFtools-0.1.16-GCC-10.2.0.eb Outdated
@Micket Micket added the update label Feb 24, 2021
@Micket
Copy link
Copy Markdown
Contributor

Micket commented Feb 26, 2021

There seems to already be a VCFtools 0.1.16 for GCC 10.2.0
https://github.com/easybuilders/easybuild-easyconfigs/blob/develop/easybuild/easyconfigs/v/VCFtools/VCFtools-0.1.16-GCC-10.2.0.eb

I don't understand why this PR doesn't show up as a diff that just fixes the missing pkg-config builddep... this was opened after that file was merged. I can't see why it doesn't work. Can you please rebase this on develop?

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Feb 26, 2021

Alternative: Can you please open a new PR where we add the missing pkg-config to all recent versions of VCFtools?

@lexming lexming mentioned this pull request Mar 2, 2021
Merged
lexming
lexming requested changes Mar 2, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a PR to this one fixing the conflicts and adding pkg-config to all easyconfigs of VCFtools v0.1.16. Please check fizwit#7

@fizwit
Merge pull request #7 from lexming/VCFtools-pkgconfig
7fa813f 
add build dependency on pkg-config to VCFtools v0.1.16
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Mar 3, 2021

Test report by @lexming
SUCCESS
Build succeeded for 10 out of 10 (6 easyconfigs in total)
node301.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/658f38a6f581321527d67d3f6809612b for a full test report.

lexming
lexming approved these changes Mar 3, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming lexming added bug fix and removed update labels Mar 3, 2021
@lexming lexming added this to the next release (4.3.4?) milestone Mar 3, 2021
@lexming lexming changed the title {bio}[GCC/10.2.0] VCFtools 0.1.16 add missing build dependency on pkg-config to VCFtools 0.1.16 Mar 3, 2021
@lexming lexming dismissed Micket’s stale review March 3, 2021 22:46

review addressed by author

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Mar 3, 2021

Going in, thanks @fizwit !

@lexming lexming merged commit c1e83a0 into easybuilders:develop Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lexming lexming lexming approved these changes

@Micket Micket Micket left review comments

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.3.4

Development

Successfully merging this pull request may close these issues.

3 participants

@fizwit @Micket @lexming