Skip to content

bump JasPer version to latest 2.0.24 for 2020b generation of easyconfigs + remove easyconfigs for ancient JasPer 2.0.1.4 with GCCcore/10.2.0#12277

Merged
branfosj merged 2 commits intoeasybuilders:developfrom
boegel:fix_jasper_2020b
Feb 25, 2021
Merged

bump JasPer version to latest 2.0.24 for 2020b generation of easyconfigs + remove easyconfigs for ancient JasPer 2.0.1.4 with GCCcore/10.2.0#12277
branfosj merged 2 commits intoeasybuilders:developfrom
boegel:fix_jasper_2020b

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Feb 25, 2021

While working on OpenCV for foss/2020b (#12265), I noticed we're (probably by accident) using an ancient version of JasPer for the 2020b generation of easyconfigs...

JasPer 2.0.14 was released Sept'17 (see https://www.ece.uvic.ca/~frodo/jasper/#download), and there are several more recent releases available through https://github.com/jasper-software/jasper/releases . In addition, we already have an easyconfig for JasPer 2.0.24 with GCCcore/10.2.0 (see #12077), so we really should be using that instead.

The fact that only old releases are mentioned at https://www.ece.uvic.ca/~frodo/jasper/#download is probably what caused this.

Fallout is relatively limited for now, but it does involve Qt5, so people who already have it installed will have to rebuild it to avoid running into surprises...

@boegel
bump JasPer version to latest 2.0.24 for 2020b generation of easyconf…
5943b9b 
…igs + remove easyconfigs for ancient JasPer 2.0.1.4 with GCCcore/10.2.0
@boegel boegel added this to the next release (4.3.4?) milestone Feb 25, 2021
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 25, 2021

@boegelbot please test @ generoso
CORE_CNT=16

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 25, 2021

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12277 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12277 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 16212

Test results coming soon (I hope)...

Details

- notification for comment with ID 785817867 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 25, 2021

Test report by @boegelbot
FAILED
Build succeeded for 2 out of 3 (3 easyconfigs in total)
generoso-x-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/8f7e3dbfc710e047251713b2f125d988 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Feb 25, 2021

I did a test build, but forgot the upload. I error out with:

qjp2handler.cpp: In member function bool Jpeg2000JasperReader::write(const QImage&, int):
qjp2handler.cpp:855:41: error: pow was not declared in this scope
  855 |     const double jasperRate = minRate + pow((double(quality) / double(maxQuality)), 2) * maxRate;
      |                                         ^~~
make[5]: *** [.obj/qjp2handler.o] Error 1

Which leads me to qt/qtimageformats@704868d

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 25, 2021

@boegelbot please test @ generoso
CORE_CNT=16

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 25, 2021

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12277 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12277 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 16213

Test results coming soon (I hope)...

Details

- notification for comment with ID 785855658 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Feb 25, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
bear-pg0206u03a.bear.cluster - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/5c8effad3854d14a38295e0693578754 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 25, 2021

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node2685.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/9e900ef4509bae8892905acf2b77bca8 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 25, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
generoso-x-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/a2ee1961bffc20af7bb6d75d9b18e6d3 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 25, 2021

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node3521.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/bcf4af5ff0abb9d4055128c797f5936a for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 25, 2021

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node3152.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/5064e66af1ce2414b28a6edacc1860d8 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Feb 25, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
bear-pg0306u19a - Linux RHEL 8.2, POWER, 8335-GTX (power9le), Python 3.6.8
See https://gist.github.com/a8b23101f0f442328538fe4f44096474 for a full test report.

branfosj
branfosj approved these changes Feb 25, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Feb 25, 2021

Going in, thanks @boegel!

@branfosj branfosj merged commit c77b8ac into easybuilders:develop Feb 25, 2021
@branfosj branfosj mentioned this pull request Feb 25, 2021
Merged
@boegel boegel deleted the fix_jasper_2020b branch February 25, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@branfosj branfosj branfosj approved these changes

Assignees

No one assigned

Labels

bug fix change

Projects

None yet

Milestone

4.3.4

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @branfosj