Skip to content

add patch for Bison 3.7.1 to fix build error on old OS versions #12291

Merged
boegel merged 3 commits intoeasybuilders:developfrom
patbel-pwr:Bison-3.7.1_fix_old_gcc
Jan 14, 2024
Merged

add patch for Bison 3.7.1 to fix build error on old OS versions #12291
boegel merged 3 commits intoeasybuilders:developfrom
patbel-pwr:Bison-3.7.1_fix_old_gcc

Conversation

@patbel-pwr
Copy link
Copy Markdown
Contributor

@patbel-pwr patbel-pwr commented Feb 25, 2021 •
edited
Loading

Bison-3.7.1.eb was crashing on Scientific Linux 6.10 with following error:
src/parse-simulation.c:61: error: redefinition of typedef 'parse_state' src/parse-simulation.h:74: note: previous declaration of 'parse_state' was here
fix is to change the definition in parse_simulation.c to be of just the struct.

Patch is commented out in Bison-3.7.1.eb with comment above on when to uncomment.

There was no issue created for this as we discussed it and I received help @ slack.

@patbel-pwr patbel-pwr changed the title Fix build error on old GCC [Bison-3.7.1] Fix build error on old GCC Feb 25, 2021
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 25, 2021

@patbel-pwr: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/600739585
Output from first failing test suite run:

FAIL: test_style_conformance (test.easyconfigs.styletests.StyleTest)
Check the easyconfigs for style
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/easyconfigs/styletests.py", line 57, in test_style_conformance
    self.assertEqual(result, 0, "Found code style errors (and/or warnings): %s" % result)
AssertionError: Found code style errors (and/or warnings): 2

----------------------------------------------------------------------
Ran 11523 tests in 422.433s

FAILED (failures=1)
ERROR: Not all tests were successful.

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice you me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

@boegel boegel added the bug fix label Feb 26, 2021
@boegel boegel added this to the 4.x milestone Feb 26, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 26, 2021

If this patch won't cause problems on other operating systems, why not simply always apply it?

@zao Thoughts?

@zao
Copy link
Copy Markdown
Contributor

zao commented Feb 26, 2021

It could indeed be unconditional.

@zao
Copy link
Copy Markdown
Contributor

zao commented Feb 26, 2021

I've verified this assumption by successfully building on Ubuntu 20.04 with their 9.3.0 system compiler, still good.

@boegel boegel changed the title [Bison-3.7.1] Fix build error on old GCC add patch for Bison 3.7.1 to fix build error on old OS versions Jan 14, 2024
@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 14, 2024

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3147.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/c7b41a821a54575225e3daf93a9ef0f5 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 14, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 14, 2024

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=12291 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_12291 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12601

Test results coming soon (I hope)...

Details

- notification for comment with ID 1890892369 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 14, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/4964bd13f125135908e60f1a2a3141fc for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 14, 2024

@boegelbot please test @ jsc-zen2

@boegel boegel modified the milestones: 4.x, release after 4.9.0 Jan 14, 2024
boegel
boegel approved these changes Jan 14, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 14, 2024

Going in, thanks @patbel-pwr!

@boegel boegel merged commit 0a5e581 into easybuilders:develop Jan 14, 2024
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 14, 2024

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=12291 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_12291 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4076

Test results coming soon (I hope)...

Details

- notification for comment with ID 1890894127 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 14, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/af1f0677a1b423a0fb533a98795950df for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.1

Development

Successfully merging this pull request may close these issues.

4 participants

@patbel-pwr @boegelbot @boegel @zao