Skip to content

add sanity check commands for vorbis-tools#12304

Merged
lexming merged 1 commit intoeasybuilders:developfrom
boegel:20210227092708_new_pr_vorbis-tools142
Mar 2, 2021
Merged

add sanity check commands for vorbis-tools#12304
lexming merged 1 commit intoeasybuilders:developfrom
boegel:20210227092708_new_pr_vorbis-tools142

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Feb 27, 2021

(created using eb --new-pr)
vcut doesn't support --help, so I had to deal with that separately in sanity_check_paths

@boegel boegel added this to the next release (4.3.4?) milestone Feb 27, 2021
@boegel boegel requested a review from Micket February 27, 2021 08:27
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 27, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3102.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/1dcf811ac5251610fc7e2beea5f54644 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Feb 27, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3501.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/a8f0f8cd76bb6073a5a7cd2cc1cba614 for a full test report.

Micket
Micket previously requested changes Feb 27, 2021
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Mar 2, 2021

Test report by @lexming
SUCCESS
Build succeeded for 4 out of 4 (1 easyconfigs in total)
node356.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/0b2756dea5118f668cf138b61d77dd87 for a full test report.

Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming lexming dismissed Micket’s stale review March 2, 2021 21:38

review addressed by author

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Mar 2, 2021

Going in, thanks @boegel !

@lexming lexming merged commit 19360fe into easybuilders:develop Mar 2, 2021
@boegel boegel deleted the 20210227092708_new_pr_vorbis-tools142 branch March 6, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants