Skip to content

add missing groff build dependency for Perl 5.30.0 and 5.32.0#12307

Merged
boegel merged 3 commits intoeasybuilders:developfrom
Mormacill:20210228192437_new_pr_groff1224
Feb 28, 2021
Merged

add missing groff build dependency for Perl 5.30.0 and 5.32.0#12307
boegel merged 3 commits intoeasybuilders:developfrom
Mormacill:20210228192437_new_pr_groff1224

Conversation

@Mormacill
Copy link
Copy Markdown
Contributor

@Mormacill Mormacill commented Feb 28, 2021

(created using eb --new-pr)

edit (by @boegel): fixes #10552

Mormacill and others added 3 commits February 28, 2021 19:24
provides nroff tool requires to install man pages
provides nroff tool requires to install man pages
@Mormacill
Copy link
Copy Markdown
Contributor Author

You might link issue #10552, this pr should solve this.

@boegel boegel changed the title {tools}[GCCcore/10.2.0,GCCcore/8.3.0] groff v1.22.4 add missing groff build dependency for Perl 5.30.0 and 5.32.0 Feb 28, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 28, 2021

@boegelbot please test @ generoso

@boegel boegel added the bug fix label Feb 28, 2021
@boegel boegel added this to the next release (4.3.4?) milestone Feb 28, 2021
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12307 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12307 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 16248

Test results coming soon (I hope)...

Details

- notification for comment with ID 787507631 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 28, 2021

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (4 easyconfigs in total)
node3101.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/12b1fb3ea2e3aa487e3534b3d66e80da for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/d83c3f498b292edd44bf7200c9b3e1bc for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 28, 2021

Going in, thanks @Mormacill!

@boegel boegel merged commit d01814b into easybuilders:develop Feb 28, 2021
@akesandgren
Copy link
Copy Markdown
Contributor

Unfortunately this isn't that easy.
We have a cyclic dependency here:
Perl deps on groff which deps on makeinfo which deps on perl.

I have a potential fix for this which includes making a minimal perl only used for building a minimal makeinfo which is only a builddep for groff.

@boegel This was discussed a bit in the slack but never decided on.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 1, 2021

@akesandgren Ugh, totally overlooked that.

Please open an issue on this, using a bare Perl as build dep for makeinfo makes sense, I guess.

Also, ideally, the test suite would have caught this, but I'm not sure how easy it is to check for a cycle in the dep graph...

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 1, 2021

@akesandgren Hold on, currently the makeinfo easyconfigs don't depend on Perl at all (which may explain why the test suite didn't trip over this).

Are you saying they should?

@akesandgren
Copy link
Copy Markdown
Contributor

See, #12067

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Perl-5.30.0-GCCcore-8.3.0.eb fails in the sanity check stage

4 participants