Skip to content

{chem}[foss-2020b,intel-2020b] DL_POLY_4 v5.0.0#12324

Merged
lexming merged 3 commits intoeasybuilders:developfrom
alinelena:develop
Mar 6, 2021
Merged

{chem}[foss-2020b,intel-2020b] DL_POLY_4 v5.0.0#12324
lexming merged 3 commits intoeasybuilders:developfrom
alinelena:develop

Conversation

@alinelena
Copy link
Copy Markdown
Contributor

No description provided.

@alinelena alinelena changed the title add dl poly 4 easyconfigs {chem}[foss-2020b][intel-2020b]add dl poly 4 easyconfigs Mar 2, 2021
@zao
Copy link
Copy Markdown
Contributor

zao commented Mar 2, 2021

Test report by @zao
FAILED
Build succeeded for 0 out of 2 (2 easyconfigs in total)
eb-u2004 - Linux Ubuntu 20.04, x86_64, Intel(R) Core(TM) i7-8700K CPU @ 3.70GHz, Python 3.8.5
See https://gist.github.com/5b7258cdbfa635a1e4985fb7a601c157 for a full test report.

@zao
Copy link
Copy Markdown
Contributor

zao commented Mar 2, 2021

  • A build dependency on CMake is needed.
  • Is the tar dance with the sources necessary, can't it be handled with filename and/or download_filename?
  • Normally sources_urls is separate from the sources list unless there's a need to avoid collisions.

@boegelbot

This comment has been minimized.

Micket
Micket previously requested changes Mar 2, 2021
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in addition to what zao wrote

Comment thread easybuild/easyconfigs/d/DL_POLY_4/DL_POLY_4-5.0.0-foss-2020b.eb Outdated
Comment thread easybuild/easyconfigs/d/DL_POLY_4/DL_POLY_4-5.0.0-intel-2020b.eb Outdated
@zao
Copy link
Copy Markdown
Contributor

zao commented Mar 2, 2021

Test report by @zao
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
eb-u2004 - Linux Ubuntu 20.04, x86_64, Intel(R) Core(TM) i7-8700K CPU @ 3.70GHz, Python 3.8.5
See https://gist.github.com/71a1f38194c7b56ab3f8df99560a1d0c for a full test report.

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Mar 5, 2021

Test report by @lexming
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node354.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/19f691531823416295fb84f59bd55347 for a full test report.

Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming lexming added the new label Mar 6, 2021
@lexming lexming added this to the next release (4.3.4?) milestone Mar 6, 2021
@lexming lexming dismissed Micket’s stale review March 6, 2021 00:54

review addressed by author

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Mar 6, 2021

Going in, thanks @alinelena !

@lexming lexming merged commit ed896cc into easybuilders:develop Mar 6, 2021
@boegel boegel changed the title {chem}[foss-2020b][intel-2020b]add dl poly 4 easyconfigs {chem}[foss-2020b,intel-2020b] DL_POLY_4 v5.0.0 Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants