Skip to content

{data}[foss/2019b] Arrow v0.16.0, pyABC v0.10.4 w/ Python 3.7.4#12329

Merged
branfosj merged 6 commits intoeasybuilders:developfrom
dithwick:20210303122000_new_pr_Arrow0160
Mar 13, 2021
Merged

{data}[foss/2019b] Arrow v0.16.0, pyABC v0.10.4 w/ Python 3.7.4#12329
branfosj merged 6 commits intoeasybuilders:developfrom
dithwick:20210303122000_new_pr_Arrow0160

Conversation

@dithwick
Copy link
Copy Markdown
Contributor

@dithwick dithwick commented Mar 3, 2021

(created using eb --new-pr)

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Mar 5, 2021

Test report by @lexming
FAILED
Build succeeded for 2 out of 3 (2 easyconfigs in total)
node320.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/90eb7d789ba6d6709152a5341f75ec4d for a full test report.

lexming
lexming previously requested changes Mar 6, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My test failed because pyABC is missing the following dependency:

pyabc 0.10.4 requires bkcharts, which is not installed.

@dithwick
Copy link
Copy Markdown
Contributor Author

dithwick commented Mar 6, 2021

Thanks, I think bkcharts is no longer used but was left in the requirements. I'll see what the best way to fix it is.

@dithwick
Copy link
Copy Markdown
Contributor Author

dithwick commented Mar 6, 2021

Just for reference. ICB-DCM/pyABC#326

@dithwick
Copy link
Copy Markdown
Contributor Author

dithwick commented Mar 6, 2021

The patch I've added won't be necessary for 0.10.5 onwards but the requirements for that release don't align well with this toolchain.

boegel
boegel previously requested changes Mar 7, 2021
View reviewed changes
Comment thread easybuild/easyconfigs/p/pyABC/pyABC-0.10.4-foss-2019b-Python-3.7.4.eb Outdated
@boegel boegel added this to the 4.x milestone Mar 7, 2021
@dithwick dithwick requested review from boegel and lexming March 8, 2021 10:23
branfosj
branfosj reviewed Mar 13, 2021
View reviewed changes
Comment thread easybuild/easyconfigs/a/Arrow/Arrow-0.16.0-foss-2019b-Python-3.7.4.eb Outdated
@branfosj branfosj dismissed stale reviews from lexming and boegel March 13, 2021 11:55

Problem has been fixed

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Mar 13, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 13, 2021

@branfosj: Request for testing this PR well received on generoso

PR test command 'EB_PR=12329 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12329 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 16357

Test results coming soon (I hope)...

Details

- notification for comment with ID 798238680 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

branfosj
branfosj approved these changes Mar 13, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Mar 13, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/9e92c614e94a9a8164253deac116ab4d for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 13, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in total)
generoso-c1-s-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/f10f603a29d68d7bf6d2dd3db88f1547 for a full test report.

@branfosj branfosj modified the milestones: 4.x, next release (4.3.4?) Mar 13, 2021
@branfosj
Copy link
Copy Markdown
Member

branfosj commented Mar 13, 2021

Going in, thanks @dithwick!

@branfosj branfosj merged commit 1f4fecc into easybuilders:develop Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@branfosj branfosj branfosj approved these changes

@boegel boegel Awaiting requested review from boegel

@lexming lexming Awaiting requested review from lexming

Assignees

No one assigned

Labels

new update

Projects

None yet

Milestone

4.3.4

Development

Successfully merging this pull request may close these issues.

6 participants

@dithwick @lexming @branfosj @boegelbot @boegel @Micket