Skip to content

revert to Seaborn 0.10.1 as dependency for NanoPlot 1.33.0#12345

Merged
lexming merged 1 commit intoeasybuilders:developfrom
boegel:20210305184736_new_pr_NanoPlot1330
Mar 5, 2021
Merged

revert to Seaborn 0.10.1 as dependency for NanoPlot 1.33.0#12345
lexming merged 1 commit intoeasybuilders:developfrom
boegel:20210305184736_new_pr_NanoPlot1330

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 5, 2021 •
edited
Loading

(created using eb --new-pr)

This change is required to fix a problem that arises due to backwards-incompatible changes in Seaborn 0.11.x:

AttributeError: 'PathCollection' object has no property 'stat_func'

See also wdecoster/NanoPlot#201

@boegel boegel added this to the next release (4.3.4?) milestone Mar 5, 2021
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 5, 2021

@boegelbot please test @ generoso

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 5, 2021

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3501.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/6ef7f9a5b575056a3cbd25c36e209cf9 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 5, 2021

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3110.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/4a70608b7a70db30918ed687408d63b1 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 5, 2021

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12345 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12345 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 16320

Test results coming soon (I hope)...

Details

- notification for comment with ID 791580453 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 5, 2021

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node2698.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/d8398a46c4a4666913edf0182c636467 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 5, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/0d78b8e63945847fcaf7e0c72805a115 for a full test report.

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Mar 5, 2021

Test report by @lexming
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node305.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/9b934af049cbce6cf0b6e9c09fd9874d for a full test report.

lexming
lexming approved these changes Mar 5, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Mar 5, 2021

Going in, thanks @boegel !

@lexming lexming merged commit d894b18 into easybuilders:develop Mar 5, 2021
@boegel boegel deleted the 20210305184736_new_pr_NanoPlot1330 branch March 6, 2021 08:20
@boegel boegel added the change label Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lexming lexming lexming approved these changes

Assignees

No one assigned

Labels

bug fix change

Projects

None yet

Milestone

4.3.4

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @lexming