Skip to content

add easyconfigs for cuDNN 8.1.x and update 8.0.x easyconfigs with a download location#12368

Merged
boegel merged 4 commits intoeasybuilders:developfrom
robert-mijakovic:20210310153807_new_pr_cuDNN80430
Jun 9, 2021
Merged

add easyconfigs for cuDNN 8.1.x and update 8.0.x easyconfigs with a download location#12368
boegel merged 4 commits intoeasybuilders:developfrom
robert-mijakovic:20210310153807_new_pr_cuDNN80430

Conversation

@robert-mijakovic
Copy link
Copy Markdown
Contributor

@robert-mijakovic robert-mijakovic commented Mar 10, 2021 •
edited by boegel
Loading

(created using eb --new-pr)

Edit: Requires easybuilders/easybuild-easyblocks#2356 for armsbsa (AARCH64)

@branfosj branfosj added this to the 4.x milestone Mar 10, 2021
Micket
Micket previously requested changes Mar 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to remove a few ppc variants

Comment thread easybuild/easyconfigs/c/cuDNN/cuDNN-8.0.4.30-CUDA-11.0.2.eb
Comment thread easybuild/easyconfigs/c/cuDNN/cuDNN-8.0.4.30-CUDA-11.1.1.eb
@robert-mijakovic
Copy link
Copy Markdown
Contributor Author

robert-mijakovic commented Mar 16, 2021

@Micket Thank you for noticing. This was actually a copy-paste problem. It is fixed.

@robert-mijakovic
Copy link
Copy Markdown
Contributor Author

robert-mijakovic commented May 4, 2021

@Micket Can you approve this one?

boegel
boegel requested changes Jun 8, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only commented on one easyconfig, but the same remarks apply to the others (where applicable)

Comment thread easybuild/easyconfigs/c/cuDNN/cuDNN-8.0.4.30-CUDA-11.0.2.eb
Comment thread easybuild/easyconfigs/c/cuDNN/cuDNN-8.0.4.30-CUDA-11.0.2.eb Outdated
@robert-mijakovic
Copy link
Copy Markdown
Contributor Author

robert-mijakovic commented Jun 9, 2021

@boegel I forgot to mention that it is done.

@boegel boegel changed the title Adds cuDNN 8.1.x and updates 8.0.x with a download location add easyconfigs for cuDNN 8.1.x and update 8.0.x easyconfigs with a download location Jun 9, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 9, 2021

@boegelbot please test @ generoso

@boegel boegel dismissed Micket’s stale review June 9, 2021 17:38

PPC added back

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 9, 2021

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12368 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12368 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17402

Test results coming soon (I hope)...

Details

- notification for comment with ID 857898262 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 9, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/ffdfd325baacf2b93e47f06135e2289e for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 9, 2021

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
mgmt.select-pika.citc.local - Linux centos linux 8.3.2011, x86_64, AMD EPYC 7571, Python 3.6.8
See https://gist.github.com/6c1b689c248d493827b087bd22281602 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 9, 2021

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
easybuild2.novalocal - Linux centos linux 8.3.2011, POWER, IBM pSeries (emulated by qemu) (power9le), Python 3.6.8
See https://gist.github.com/0d5a72d027915f9d4fdcd09be5604c28 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 9, 2021

Going in, thanks @robert-mijakovic!

@boegel boegel merged commit bfee0ae into easybuilders:develop Jun 9, 2021
@boegel boegel modified the milestones: 4.x, next release (4.4.1) Jun 9, 2021
@boegel boegel added enhancement and removed change labels Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

@Micket Micket Micket left review comments

Assignees

No one assigned

Labels

enhancement update

Projects

None yet

Milestone

4.4.1

Development

Successfully merging this pull request may close these issues.

5 participants

@robert-mijakovic @boegel @boegelbot @Micket @branfosj