Skip to content

consistently include Keras-Applications and Keras-Preprocessing extensions in Keras 2.3.1 easyconfigs#12375

Merged
branfosj merged 1 commit intoeasybuilders:developfrom
boegel:20210311134426_new_pr_Keras231
Mar 13, 2021
Merged

consistently include Keras-Applications and Keras-Preprocessing extensions in Keras 2.3.1 easyconfigs#12375
branfosj merged 1 commit intoeasybuilders:developfrom
boegel:20210311134426_new_pr_Keras231

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 11, 2021

(created using eb --new-pr)

@branfosj branfosj added this to the 4.x milestone Mar 11, 2021
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 12, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 12, 2021

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12375 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12375 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 16347

Test results coming soon (I hope)...

Details

- notification for comment with ID 797405434 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 12, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/afe1174971799c3b5c2295b1334482c9 for a full test report.

branfosj
branfosj approved these changes Mar 13, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Mar 13, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/157539e48be4f939db9983583f08c1c3 for a full test report.

@branfosj branfosj modified the milestones: 4.x, next release (4.3.4?) Mar 13, 2021
@branfosj
Copy link
Copy Markdown
Member

branfosj commented Mar 13, 2021

Going in, thanks @boegel!

@branfosj branfosj merged commit 46bb01a into easybuilders:develop Mar 13, 2021
@boegel boegel deleted the 20210311134426_new_pr_Keras231 branch March 13, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@branfosj branfosj branfosj approved these changes

Assignees

No one assigned

Labels

code cleanup

Projects

None yet

Milestone

4.3.4

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @branfosj