{bio}[GCC/4.8.4] biocompressors: DSRC-2.0rc, fastqz-1.5, fqzcomp-4.6, Quip-1.1.8, SCALCE-2.7, ZPAQ-7.00 (REVIEW)#1242
Conversation
Signed-off-by: Fotis Georgatos <[email protected]>
Signed-off-by: Fotis Georgatos <[email protected]>
|
Test PASSed. |
1 similar comment
|
Test PASSed. |
Signed-off-by: Fotis Georgatos <[email protected]>
|
Test PASSed. |
|
Test PASSed. |
|
Test FAILed. |
|
Test PASSed. |
|
Test report by @fgeorgatos |
|
@boegel: DSRC is currently provided via github only, so the Binary version has been preferred for now; if this is an issue, I could drop it from this PR. Otherwise, we just need one more review over here. |
There was a problem hiding this comment.
versionless 'source', so include a checksum for it?
|
Jenkins: test this please |
|
Refer to this link for build results (access rights to CI server needed): |
Signed-off-by: Fotis Georgatos <[email protected]>
Signed-off-by: Fotis Georgatos <[email protected]>
|
Refer to this link for build results (access rights to CI server needed): |
|
Test report by @fgeorgatos |
|
Refer to this link for build results (access rights to CI server needed): |
|
OK, here it is; bug fixed and retested. Just make your judicium on the pod2man bit. |
|
Test report by @fgeorgatos |
There was a problem hiding this comment.
Either include a build dependency for pod2man, or remove this all together...
As is, this is a liability for breaking this build...
There was a problem hiding this comment.
This is interesting:
$ rpm -q --whatprovides `which pod2man`
perl-5.10.1-136.el6.x86_64
and indeed:
$ module load Perl/5.16.3-goolf-1.4.10-bare
$ which pod2man
/gpfs/scratch/projects/project_gpilot/vsc40023/software/Perl/5.16.3-goolf-1.4.10-bare/bin/pod2man
So, adding a Perl build on top of GCC/4.8.2 in here as a build dependency would do it!
add Perl as build dep for ZPAQ
|
@boegel: |
|
Refer to this link for build results (access rights to CI server needed): |
|
@fgeorgatos: the only alternative is removed the use of |
|
@fgeorgatos: this needs fgeorgatos#36... |
include missing '-bare' versionsuffix for Perl builddep in ZPAQ easyconfig
|
@boegel: OK, merged; I think we (I) have entered bikesheding mode, so I just let go ;-) |
|
Test report by @boegel |
|
Refer to this link for build results (access rights to CI server needed): |
|
Looking great now, going in. Thanks @fgeorgatos! |
{bio}[GCC/4.8.4] DSRC-2.0rc, fastqz-1.5, fqzcomp-4.6, Quip-1.1.8, SCALCE-2.7, ZPAQ-7.00 (REVIEW)
|
Pointers for future work under the same thread (if anybody gets interested in this anytime soon): also, keep an eye on: http://ga4gh.org/#/fileformats-team |
Signed-off-by: Fotis Georgatos [email protected]