Skip to content

Stop tests changing the EasyBuild easyconfigs#12454

Merged
boegel merged 3 commits intoeasybuilders:developfrom
branfosj:stop_tests_overwriting_eb_ecs
Mar 23, 2021
Merged

Stop tests changing the EasyBuild easyconfigs#12454
boegel merged 3 commits intoeasybuilders:developfrom
branfosj:stop_tests_overwriting_eb_ecs

Conversation

@branfosj
Copy link
Copy Markdown
Member

When the tests are run they changes the EasyBuild easyconfigs, to replace

toolchain = {'name': 'dummy', 'version': 'dummy'}

with

toolchain = SYSTEM

This changes the tests to just not do the check for the dummy toolchain on the EasyBuild easyconfigs.

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added this to the next release (4.3.4?) milestone Mar 23, 2021
@boegel boegel added the bug fix label Mar 23, 2021
@boegel boegel merged commit 50209d1 into easybuilders:develop Mar 23, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 23, 2021

Related to this: we should avoid that EasyBuild produces a warning when it's installing an easyconfig file for EasyBuild which still has dummy a toolchain, since we know it's OK there...

@branfosj branfosj deleted the stop_tests_overwriting_eb_ecs branch March 23, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants