fix sanity check error for OpenCV v4.5.1 by adding (and using) freetype and HarfBuzz dependencies#12517
Conversation
There was a problem hiding this comment.
What's this XXXXX configure option about?
There was a problem hiding this comment.
That's totally weird code in OpenCV to prevent configure from wiping _LINK_LIBRARIES: https://github.com/opencv/opencv/blob/6e8daaec0f46aaba9ea22e2afce47307b1dbff9f/cmake/OpenCVUtils.cmake#L861
It seems they put it there as a fix to prevent exactly what's happening, ocv_check_modules not being able to recognize freetype and harfbuzz...
There was a problem hiding this comment.
I think it's worth adding a comment in the easyconfig file above this line to clarify that, because it looks really weird...
There was a problem hiding this comment.
Comment added (finally!)
|
@guimou It would be better to fix this in the OpenCV easyblock, or you up for looking into that? |
I could have a look. But unless I'm mistaken, this easyblock does not include the contrib libraries? Which is why I guess @Micket created this package in the first place. I don't know, I just tried to correct this package so that I could install latest OpenCV version. |
There was a problem hiding this comment.
I think it's worth adding a comment in the easyconfig file above this line to clarify that, because it looks really weird...
a339e49 to
9c92440
Compare
|
@boegelbot please test @ generoso |
|
@boegel: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 909609112 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
Test report by @boegel |
|
Going in, thanks @guimou! |
fixes #12491
Freetype and Harfbuzz are required to build freetype: https://github.com/opencv/opencv_contrib/tree/master/modules/freetype
=> Added those modules as dependencies
OpenCV contrib bug in ocv_check_modules prevents detection of Freetype and HarfBuzz, required to build freetype module, ref:
=> Applied configopts to "force detection" of the module as per described workaround in issue 2239.
Module requires Python 3:
=> Added configopt to disable Python2 compilation (removes error messages)