Skip to content

avoid 0.0.0 install version for various Python apps#12522

Merged
akesandgren merged 2 commits intoeasybuilders:developfrom
boegel:20210405133829_new_pr_deepdiff502
Apr 6, 2021
Merged

avoid 0.0.0 install version for various Python apps#12522
akesandgren merged 2 commits intoeasybuilders:developfrom
boegel:20210405133829_new_pr_deepdiff502

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Apr 5, 2021 •
edited
Loading

(created using eb --new-pr)

required because of easybuilders/easybuild-easyblocks#2367

@boegel boegel added the bug fix label Apr 5, 2021
@boegel boegel added this to the next release (4.3.4?) milestone Apr 5, 2021
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Apr 5, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 5, 2021

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12522 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12522 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 16491

Test results coming soon (I hope)...

Details

- notification for comment with ID 813353398 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 5, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/d45dd3f06b54e8c29e673b4111c69920 for a full test report.

@easybuilders easybuilders deleted a comment from boegelbot Apr 5, 2021
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Apr 5, 2021

Test report by @boegel
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in total)
node3107.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/afd01f5323fc9ca1e16698db349e5023 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Apr 6, 2021

Test report by @boegel
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in total)
node3131.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/6bc0e5b089006259866b73d782ddc44c for a full test report.

akesandgren
akesandgren approved these changes Apr 6, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented Apr 6, 2021

Going in, thanks @boegel!

@akesandgren akesandgren merged commit 4fba281 into easybuilders:develop Apr 6, 2021
@boegel boegel deleted the 20210405133829_new_pr_deepdiff502 branch April 6, 2021 15:36
@Flamefire
Copy link
Copy Markdown
Contributor

Flamefire commented Apr 21, 2021 •
edited
Loading

Just FTR: This could have also been fixed by using the WHL files instead (which is one of the reasons I wanted to enhance support for those)
Edit: Or maybe better: By updating setuptools and setuptools_scm as required by keyring after jaraco/keyring@0bf3d43#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7

@Flamefire Flamefire mentioned this pull request Apr 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akesandgren akesandgren akesandgren approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@boegel @boegelbot @akesandgren @Flamefire