Skip to content

Enable USER_SDPD package and disable building docs in LAMMPS 3Mar2020#12527

Merged
boegel merged 1 commit intoeasybuilders:developfrom
branfosj:20210406134903_new_pr_LAMMPS3Mar2020
Apr 6, 2021
Merged

Enable USER_SDPD package and disable building docs in LAMMPS 3Mar2020#12527
boegel merged 1 commit intoeasybuilders:developfrom
branfosj:20210406134903_new_pr_LAMMPS3Mar2020

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Apr 6, 2021 •
edited
Loading

(created using eb --new-pr)

I've hit both #12211 and #12373 while testing LAMMPS builds. They are separate issues, but both are fixed if we disable building the docs.

@branfosj branfosj added this to the next release (4.3.4?) milestone Apr 6, 2021
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Apr 6, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 6, 2021

@branfosj: Request for testing this PR well received on generoso

PR test command 'EB_PR=12527 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12527 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 16494

Test results coming soon (I hope)...

Details

- notification for comment with ID 814105428 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Apr 6, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
bear-pg0206u16a.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/68c657b53bb6418bbc78ef438d177065 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 6, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/4ea67b11c1af883ab75c2d79dd5880f2 for a full test report.

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Apr 6, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
bear-pg0211u12a.bear.cluster - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/0e01194156d1618e1e722423f992583c for a full test report.

boegel
boegel approved these changes Apr 6, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 6, 2021

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
node2700.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/0040646c84c5bcbdac0d18bc9f157d5a for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 6, 2021

Going in, thanks @branfosj!

@boegel boegel merged commit acbc826 into easybuilders:develop Apr 6, 2021
@branfosj branfosj deleted the 20210406134903_new_pr_LAMMPS3Mar2020 branch April 6, 2021 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix enhancement

Projects

None yet

Milestone

4.3.4

Development

Successfully merging this pull request may close these issues.

3 participants

@branfosj @boegelbot @boegel