Skip to content

enhance RStudio-Server, add patch to inherit environment variables, add sanity check commands to verify installation#12544

Merged
branfosj merged 13 commits intoeasybuilders:developfrom
ocaisa:20210407134427_new_pr_RStudio-Server131093
May 15, 2021
Merged

enhance RStudio-Server, add patch to inherit environment variables, add sanity check commands to verify installation#12544
branfosj merged 13 commits intoeasybuilders:developfrom
ocaisa:20210407134427_new_pr_RStudio-Server131093

Conversation

@ocaisa
Copy link
Copy Markdown
Member

@ocaisa ocaisa commented Apr 7, 2021

(created using eb --new-pr)

@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented Apr 7, 2021

Test report by @ocaisa
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz, Python 3.6.8
See https://gist.github.com/5612c7f24d3f366f391130bfd6f9bada for a full test report.

@ocaisa ocaisa added the bug fix label Apr 7, 2021
ocaisa
ocaisa commented Apr 7, 2021
View reviewed changes
Comment thread easybuild/easyconfigs/r/RStudio-Server/RStudio-Server-1.3.1093-foss-2020a-Java-11-R-4.0.0.eb Outdated
boegel
boegel previously requested changes Apr 7, 2021
View reviewed changes
Comment thread easybuild/easyconfigs/r/RStudio-Server/rstudio-1.2.1335.patch
@boegel boegel added this to the release after 4.3.4 milestone Apr 7, 2021
ocaisa
ocaisa commented Apr 7, 2021
View reviewed changes
Comment thread easybuild/easyconfigs/r/RStudio-Server/RStudio-Server-1.2.1335-fix_env.patch
@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented Apr 7, 2021

Test report by @ocaisa
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz, Python 3.6.8
See https://gist.github.com/ecc54258d87feaa467c96847933fca34 for a full test report.

@ocaisa ocaisa requested a review from boegel April 8, 2021 10:02
ocaisa added 2 commits April 13, 2021 09:36
Retain osdeps for RStudio
d4e3304 
The final executables are linked against libpam, e.g.,
```
[EESSI pilot 2021.03] $ ldd rserver | grep pam
	libpam.so.0 => /cvmfs/pilot.eessi-hpc.org/2021.03/compat/linux/x86_64/usr/lib/../lib64/libpam.so.0 (0x00007fc7331be000)
```
Move osdeps to original position
3ef8d78
ccoulombe
ccoulombe reviewed Apr 20, 2021
View reviewed changes
Comment thread easybuild/easyconfigs/r/RStudio-Server/RStudio-Server-1.3.1093_fix-data-dir.patch Outdated
@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented Apr 28, 2021

Test report by @ocaisa
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
generoso - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz, Python 3.6.8
See https://gist.github.com/60674080717d1069cb4f32de69126079 for a full test report.

ocaisa
ocaisa commented Apr 28, 2021
View reviewed changes
Comment thread easybuild/easyconfigs/r/RStudio-Server/RStudio-Server-1.3.1093-foss-2020a-Java-11-R-4.0.0.eb Outdated
@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented Apr 28, 2021

Test report by @ocaisa
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz, Python 3.6.8
See https://gist.github.com/c9b00d6bec44d13dec82c31a5a39a007 for a full test report.

@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented May 1, 2021

Test report by @ocaisa
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz, Python 3.6.8
See https://gist.github.com/cdd3a71e22a6e3b3960230734785b076 for a full test report.

@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented May 6, 2021

Test report by @ocaisa
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz, Python 3.6.8
See https://gist.github.com/d63ef2bc84f1709c65ebbc525f6ba66f for a full test report.

branfosj
branfosj approved these changes May 15, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Copy Markdown
Member

branfosj commented May 15, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0211u08b.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/0c819bf22e8d6521ed9ce4e752c30098 for a full test report.

@branfosj branfosj dismissed boegel’s stale review May 15, 2021 14:57

change made

@branfosj
Copy link
Copy Markdown
Member

branfosj commented May 15, 2021

Going in, thanks @ocaisa!

@branfosj branfosj merged commit 18ea038 into easybuilders:develop May 15, 2021
@boegel boegel changed the title Sync RStudio-Server with Compute Canada setup enhance RStudio-Server, add patch to inherit environment variables, add sanity check commands to verify installation May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@branfosj branfosj branfosj approved these changes

@boegel boegel Awaiting requested review from boegel

+2 more reviewers

@cmd-ntrf cmd-ntrf cmd-ntrf left review comments

@ccoulombe ccoulombe ccoulombe left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.4.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ocaisa @branfosj @boegel @cmd-ntrf @ccoulombe