Skip to content

Add fix to scipy to handle NaN arguments to "vi" function.#12551

Merged
boegel merged 1 commit intoeasybuilders:developfrom
akesandgren:20210408205943_new_pr_SciPy-bundle202003
Apr 12, 2021
Merged

Add fix to scipy to handle NaN arguments to "vi" function.#12551
boegel merged 1 commit intoeasybuilders:developfrom
akesandgren:20210408205943_new_pr_SciPy-bundle202003

Conversation

@akesandgren
Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

@akesandgren akesandgren requested a review from boegel April 8, 2021 19:00
@akesandgren akesandgren added this to the 4.x milestone Apr 8, 2021
@akesandgren
Copy link
Copy Markdown
Contributor Author

@boegelbot Please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@akesandgren: Request for testing this PR well received on generoso

PR test command 'EB_PR=12551 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12551 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 16513

Test results coming soon (I hope)...

Details

- notification for comment with ID 816068915 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@akesandgren
Copy link
Copy Markdown
Contributor Author

Test report by @akesandgren
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
b-cn1522.hpc2n.umu.se - Linux Ubuntu 20.04, x86_64, Intel(R) Xeon(R) Gold 6132 CPU @ 2.60GHz, Python 3.8.5
See https://gist.github.com/cef5a315d31c89d808982f93b8f586e1 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-c1-s-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/30506640bd568aab4603127cb0ad8dd5 for a full test report.

@boegel boegel modified the milestones: 4.x, next release (4.3.5?) Apr 11, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 11, 2021

@ocaisa We have an issue somewhere on failing scipy tests (which I can't seem to find...).

Would this be enough to close that?

@boegel boegel changed the title Add fix to scipy to handle NAN arguments to "vi" function. Add fix to scipy to handle NaN arguments to "vi" function. Apr 11, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 11, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2677.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/b47e30dc8d085e6a3a244cb742f48a10 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 11, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3507.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/d8fb5fd7aa1bdce2e25abbbafcb3796c for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 11, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3105.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/14dd60b6b6d6c799d55b03df469585fe for a full test report.

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 12, 2021

Going in, thanks @akesandgren!

@boegel boegel merged commit b52887b into easybuilders:develop Apr 12, 2021
@akesandgren akesandgren deleted the 20210408205943_new_pr_SciPy-bundle202003 branch April 12, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants