Skip to content

add setuptools_scm and pytest-runner extensions to Pylint easyconfigs#12599

Merged
boegel merged 2 commits intoeasybuilders:developfrom
lexming:20210414185452_new_pr_Pylint193
Apr 15, 2021
Merged

add setuptools_scm and pytest-runner extensions to Pylint easyconfigs#12599
boegel merged 2 commits intoeasybuilders:developfrom
lexming:20210414185452_new_pr_Pylint193

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented Apr 14, 2021

(created using eb --new-pr)

Fixes issue #12596 by adding setuptools_scm and pytest-runner to the extension list of Pylint. Otherwise, pip pulls the most recent versions of these packages and newer versions do not work with Python 2. These 2 packages went under radar of sanity checks because they are declared as setup_requires.

Additionally I converted the easyconfigs of Pylint v1.9.3 from Bundle to PythonBundle.

@lexming lexming added this to the next release (4.3.5?) milestone Apr 14, 2021
@lexming lexming linked an issue Apr 14, 2021 that may be closed by this pull request
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 14, 2021

Ah, this probably went unnoticed due to easybuilders/easybuild-easyblocks#2372...

Thanks for the quick fix @lexming!

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@easybuilders easybuilders deleted a comment from boegelbot Apr 14, 2021
@easybuilders easybuilders deleted a comment from boegelbot Apr 14, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 15, 2021

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
node2700.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/fd07e789b4edf516457b105e71593a1d for a full test report.

@boegel boegel changed the title add setuptools_scm and pytest-runner to Pylint add setuptools_scm and pytest-runner extensions to Pylint easyconfigs Apr 15, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 15, 2021

Going in, thanks @lexming!

@boegel boegel merged commit 418a06d into easybuilders:develop Apr 15, 2021
@lexming lexming deleted the 20210414185452_new_pr_Pylint193 branch April 15, 2021 08:00
@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Apr 15, 2021

Test report by @lexming
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
node381.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/319ffb34848e3dcb1eb6d5bb591cd364 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pylint easyconfig with Python 2.x broken?

2 participants