Skip to content

{tools}[GCCcore/10.2.0] Archive-Zip v1.68#12651

Merged
Micket merged 2 commits intoeasybuilders:developfrom
lexming:20210415181656_new_pr_Archive-Zip168
Apr 16, 2021
Merged

{tools}[GCCcore/10.2.0] Archive-Zip v1.68#12651
Micket merged 2 commits intoeasybuilders:developfrom
lexming:20210415181656_new_pr_Archive-Zip168

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented Apr 15, 2021 •
edited
Loading

(created using eb --new-pr)

Needed by #12553

@lexming lexming added the new label Apr 15, 2021
@lexming lexming added this to the 4.x milestone Apr 15, 2021
@lexming lexming mentioned this pull request Apr 15, 2021
Merged
Micket
Micket previously approved these changes Apr 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Apr 15, 2021

Was both this and #12627 both needed for VEP?

@boegelbot

This comment has been minimized.

Sign in to view
@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Apr 16, 2021

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node374.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/6c534c543ce47b255378c123748c2887 for a full test report.

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Apr 16, 2021

@Micket yes, both PRs are needed by VEP v103.1

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Apr 16, 2021

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
vera-c1 - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake), Python 2.7.5
See https://gist.github.com/849d2fc34de0a0ab177176c154e992d2 for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Apr 16, 2021

@boegelbot please test @ generoso

@Micket Micket modified the milestones: 4.x, next release (4.3.5?) Apr 16, 2021
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 16, 2021

@Micket: Request for testing this PR well received on generoso

PR test command 'EB_PR=12651 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12651 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 16832

Test results coming soon (I hope)...

Details

- notification for comment with ID 821195641 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 16, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/b84b2e71f64b06cf1e5bb24aad25e752 for a full test report.

Micket
Micket approved these changes Apr 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Apr 16, 2021

Going in, thanks @lexming!

@Micket Micket merged commit 416034b into easybuilders:develop Apr 16, 2021
@lexming lexming deleted the 20210415181656_new_pr_Archive-Zip168 branch April 16, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@lexming @Micket @boegelbot