Skip to content

add missing Python & Perl dependencies to for AUGUSTUS v3.4.0 with foss/2020b#12662

Merged
Micket merged 6 commits intoeasybuilders:developfrom
krometis:jkchanges
Apr 20, 2021
Merged

add missing Python & Perl dependencies to for AUGUSTUS v3.4.0 with foss/2020b#12662
Micket merged 6 commits intoeasybuilders:developfrom
krometis:jkchanges

Conversation

@krometis
Copy link
Copy Markdown
Contributor

Per #12660

@Micket Micket added the bug fix label Apr 16, 2021
@Micket Micket added this to the next release (4.3.5?) milestone Apr 16, 2021
@Micket
Copy link
Copy Markdown
Contributor

Micket commented Apr 16, 2021

Would you mind including the 2020a version as well?
It needs to also include a verionsuffix for Python like all the stuff did in 2020a.

@krometis
Copy link
Copy Markdown
Contributor Author

krometis commented Apr 16, 2021

It looks like I screwed this up:

  1. I correctly submitted a PR for AUGUSTUS
  2. I then got full of myself and decided I'd also submit a PR for a newer OpenMM build that I had lying around
  3. I screwed up (2) and somehow added it to (1)

I don't know how to untangle the two now. I'm sorry about this...

It sounds like you want the same simple change to AUGUSTUS-3.4.0-foss-2020a.eb but I'm hesitant to try to add anything else since this is already all messed up.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Apr 16, 2021

So, alternatives in my opinion are

  1. Just add Python as a build dep to satisfy the test-suite
  2. Add Python and Perl as deps and also add modextrapaths = {'PATH': 'scripts'} (otherwise these deps don't do much at runtime anyway)

edit: AUGUSTUS_SCRIPTS_PATH was already used i see. Hm, Well, maybe these scripts aren't meant to be called directly? I'm not at all familiar with this software. Perhaps the PATH variable isn't necessary.. but I do think we should add Perl and Python as normal deps.

Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add Perl as a dep.

@easybuilders easybuilders deleted a comment from boegelbot Apr 16, 2021
Comment thread easybuild/easyconfigs/a/AUGUSTUS/AUGUSTUS-3.4.0-foss-2020b.eb Outdated
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Apr 19, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@Micket: Request for testing this PR well received on generoso

PR test command 'EB_PR=12662 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12662 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 16856

Test results coming soon (I hope)...

Details

- notification for comment with ID 822538608 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/69a7be9ea4785883facdbb96ea4a4f2c for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Apr 20, 2021

Going in, thanks @krometis!

@Micket Micket merged commit 4e7b2d6 into easybuilders:develop Apr 20, 2021
@boegel boegel changed the title Add Python dependency to AUGUSTUS-3.4.0-foss-2020b.eb add missing Python & Perl dependencies to for AUGUSTUS v3.4.0 with foss/2020b Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants