Skip to content

{chem}[fosscuda/2020b] cryoDRGN v0.3.2 w/ Python 3.8.6#12704

Merged
boegel merged 9 commits intoeasybuilders:developfrom
jfgrimm:20210421151913_new_pr_cryoDRGN032
May 12, 2021
Merged

{chem}[fosscuda/2020b] cryoDRGN v0.3.2 w/ Python 3.8.6#12704
boegel merged 9 commits intoeasybuilders:developfrom
jfgrimm:20210421151913_new_pr_cryoDRGN032

Conversation

@jfgrimm
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm commented Apr 21, 2021

(created using eb --new-pr)

@easybuilders easybuilders deleted a comment from boegelbot Apr 23, 2021
@easybuilders easybuilders deleted a comment from boegelbot Apr 23, 2021
@branfosj branfosj added the new label Apr 25, 2021
@branfosj branfosj added this to the 4.x milestone Apr 25, 2021
branfosj
branfosj previously requested changes Apr 25, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some minor suggestions for improvement.

Comment thread easybuild/easyconfigs/c/cryoDRGN/cryoDRGN-0.3.2-fosscuda-2020b.eb Outdated
Comment thread easybuild/easyconfigs/c/cryoDRGN/cryoDRGN-0.3.2-fosscuda-2020b.eb Outdated
Comment thread easybuild/easyconfigs/c/cryoDRGN/cryoDRGN-0.3.2-fosscuda-2020b.eb Outdated
@easybuilders easybuilders deleted a comment from boegelbot May 12, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented May 12, 2021

@boegelbot please test @ generoso

@boegel
Copy link
Copy Markdown
Member

boegel commented May 12, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3304.joltik.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6242 CPU @ 2.80GHz (cascadelake), Python 3.6.8
See https://gist.github.com/3ff7b8e6889e7dbc6d7eff7a77d32f88 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 12, 2021

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12704 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12704 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17210

Test results coming soon (I hope)...

Details

- notification for comment with ID 839986497 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 12, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-x-3 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/e1e94fe3d00b1fc6e498e814b13d6f4a for a full test report.

boegel
boegel approved these changes May 12, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel dismissed branfosj’s stale review May 12, 2021 19:07

requested changes made

@boegel
Copy link
Copy Markdown
Member

boegel commented May 12, 2021

Going in, thanks @jfgrimm!

@boegel boegel merged commit 8802f0a into easybuilders:develop May 12, 2021
@boegel boegel modified the milestones: 4.x, next release (4.4.0) May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

@branfosj branfosj branfosj left review comments

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jfgrimm @boegel @boegelbot @branfosj