Skip to content

add check to make sure that source step is not being skipped#12807

Merged
branfosj merged 5 commits intoeasybuilders:developfrom
boegel:do_not_skip_source_step
May 4, 2021
Merged

add check to make sure that source step is not being skipped#12807
branfosj merged 5 commits intoeasybuilders:developfrom
boegel:do_not_skip_source_step

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented May 4, 2021 •
edited
Loading

Skipping the source step implies not verifying checksums, so we shouldn't do that...

requires #12794 (fixes for FastTree)

@boegel boegel added this to the next release (4.3.5?) milestone May 4, 2021
@boegel boegel requested a review from branfosj May 4, 2021 09:57
@easybuilders easybuilders deleted a comment from boegelbot May 4, 2021
@branfosj
Copy link
Copy Markdown
Member

branfosj commented May 4, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
bear-pg0206u05b.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/f409e7c4a326a9480c21bba825a3d5b4 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented May 4, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bber0501u03b.bb2.cluster - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/ebe418abe86f2edbc434c018e0f8f1dd for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented May 4, 2021 •
edited
Loading

fastqz-1.5-GCC-4.8.2.eb remains to be tested. I do not have that old a GCC built.

All the rest of the changes are good.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented May 4, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
bber0501u03b.bb2.cluster - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/0ba8cff2f8832b0f4e66b6a5cf94d2db for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented May 4, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bber0501u03b.bb2.cluster - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/595e64f97d00c5819d00b9763860b999 for a full test report.

@boegel boegel added the bug fix label May 4, 2021
branfosj
branfosj approved these changes May 4, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Copy Markdown
Member

branfosj commented May 4, 2021

Going in, thanks @boegel!

@branfosj branfosj merged commit 5004efd into easybuilders:develop May 4, 2021
@boegel boegel deleted the do_not_skip_source_step branch May 4, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@branfosj branfosj branfosj approved these changes

Assignees

No one assigned

Labels

bug fix enhancement tests

Projects

None yet

Milestone

4.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @branfosj