Skip to content

{lib}[foss/2020b] dm-reverb v0.2.0 w/ Python 3.8.6#12824

Merged
Micket merged 3 commits intoeasybuilders:developfrom
lexming:20210506100242_new_pr_dm-reverb020
May 12, 2021
Merged

{lib}[foss/2020b] dm-reverb v0.2.0 w/ Python 3.8.6#12824
Micket merged 3 commits intoeasybuilders:developfrom
lexming:20210506100242_new_pr_dm-reverb020

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented May 6, 2021

(created using eb --new-pr)

Depends on easybuilders/easybuild-easyblocks#2413

@lexming lexming added the new label May 6, 2021
@lexming lexming added this to the 4.x milestone May 6, 2021
@boegelbot

This comment has been minimized.

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented May 7, 2021

Test report by @lexming
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2413
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node381.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/ede9ab6b3fee57d4f8d9ed55a7db0b50 for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented May 7, 2021

@boegelbot please test @ generoso
EB_ARGS="--include-easyblocks-from-pr=2413"

Micket
Micket previously approved these changes May 7, 2021
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Copy Markdown
Collaborator

@Micket: Request for testing this PR well received on generoso

PR test command 'EB_PR=12824 EB_ARGS="--include-easyblocks-from-pr=2413" /apps/slurm/default/bin/sbatch --job-name test_PR_12824 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17066

Test results coming soon (I hope)...

Details

- notification for comment with ID 834379377 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2413
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/49a4fc1ecc4d6a4d69f6849088150565 for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented May 7, 2021

Well that wasn't what i was hoping to see

ERROR: /tmp/boegelbot/dmreverb/0.2.0/foss-2020b/easybuild_obj/0da5ac30722e994767df782a97d19dd3/external/com_google_protobuf/BUILD:53:11: @com_google_protobuf//:protobuf_lite: missing input file 'external/com_google_protobuf/protobuf/lib/libprotobuf-lite.so', owner: '@com_google_protobuf//:protobuf/lib/libprotobuf-lite.so'

any ideas?

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented May 7, 2021

@Micket that should be a link to $EBROOTPROTOBUF/lib/libprotobuf-lite.so, is that file missing in the test system?

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented May 7, 2021

maybe the link between lib64 and lib in $EBROOTPROTOBUF is missing

@Micket
Copy link
Copy Markdown
Contributor

Micket commented May 7, 2021

@boegel Could you take a look on generoso?

@branfosj
Copy link
Copy Markdown
Member

branfosj commented May 8, 2021

I tested and my first attempt failed to build with the same issue as seen on generoso. I rebuilt protobuf and then the build of dm-reverb succeeds. The difference between the two protobuf builds was the new install includes a lib -> lib64 symlink - so easybuilders/easybuild-framework#3580

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented May 8, 2021

@branfosj nice, that confirms my suspicion. Thanks for the feedback!

@Micket
Copy link
Copy Markdown
Contributor

Micket commented May 10, 2021

Should this then have a dependency on protobuf-2.5.0-GCCcore-10.2.0.eb (or protobuf-python)?

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented May 11, 2021

@Micket sure, done in afd2dca (and I also added the rest of direct dependencies)

@Micket
Copy link
Copy Markdown
Contributor

Micket commented May 12, 2021

@boegelbot please test @ generoso
EB_ARGS="--include-easyblocks-from-pr=2413 protobuf-2.5.0-GCCcore-10.2.0.eb dm-reverb-0.2.0-foss-2020b.eb"

@boegelbot
Copy link
Copy Markdown
Collaborator

@Micket: Request for testing this PR well received on generoso

PR test command 'EB_PR=12824 EB_ARGS="--include-easyblocks-from-pr=2413 protobuf-2.5.0-GCCcore-10.2.0.eb dm-reverb-0.2.0-foss-2020b.eb" /apps/slurm/default/bin/sbatch --job-name test_PR_12824 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17083

Test results coming soon (I hope)...

Details

- notification for comment with ID 839676565 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2413
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/69054bc4884795c20ed4b3b0675b9754 for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented May 12, 2021

@boegelbot please test @ generoso
EB_ARGS="--include-easyblocks-from-pr=2413 protobuf-3.14.0-GCCcore-10.2.0.eb dm-reverb-0.2.0-foss-2020b.eb"

@boegelbot
Copy link
Copy Markdown
Collaborator

@Micket: Request for testing this PR well received on generoso

PR test command 'EB_PR=12824 EB_ARGS="--include-easyblocks-from-pr=2413 protobuf-3.14.0-GCCcore-10.2.0.eb dm-reverb-0.2.0-foss-2020b.eb" /apps/slurm/default/bin/sbatch --job-name test_PR_12824 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17084

Test results coming soon (I hope)...

Details

- notification for comment with ID 839766653 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2413
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/73e783e329e0af515dcf7533ceb28daa for a full test report.

Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented May 12, 2021

Going in, thanks @lexming!

@Micket Micket merged commit 2531cf3 into easybuilders:develop May 12, 2021
@easybuilders easybuilders deleted a comment from boegelbot May 12, 2021
@boegel boegel modified the milestones: 4.x, next release (4.4.0) May 12, 2021
@lexming lexming deleted the 20210506100242_new_pr_dm-reverb020 branch May 13, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants