Skip to content

disable usNIC by default in libfabric to avoid problems due to linking to both libnl and libnl-3#12854

Merged
boegel merged 2 commits intoeasybuilders:developfrom
ocaisa:20210512135443_new_pr_libfabric1101
May 12, 2021
Merged

disable usNIC by default in libfabric to avoid problems due to linking to both libnl and libnl-3#12854
boegel merged 2 commits intoeasybuilders:developfrom
ocaisa:20210512135443_new_pr_libfabric1101

Conversation

@ocaisa
Copy link
Copy Markdown
Member

@ocaisa ocaisa commented May 12, 2021

(created using eb --new-pr)

@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented May 12, 2021

This results in identical configuration on Generoso:

*** Built-in providers: hook_debug perf rstream shm rxd mrail rxm tcp udp verbs

so I can't test the impact of this.

This was referenced May 12, 2021
Closed
Closed
Micket
Micket approved these changes May 12, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket added the change label May 12, 2021
@Micket Micket added this to the next release (4.3.5?) milestone May 12, 2021
@boegel boegel changed the title Disable usNIC by default in libfabric disable usNIC by default in libfabric to avoid problems due to linking to both libnl and libnl-3 May 12, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented May 12, 2021

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
node2601.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/9546bdda802c551ef1f987c42b6bae2a for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 12, 2021

Before these changes, on a system that includes libnl3-devel, fi_info -l produced output like:

$ fi_info -l
usnic:
    version: 1.0
verbs:
    version: 111.0
...

With this change, the usnic entry is no longer there.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 12, 2021

@boegelbot please test @ generoso

boegel
boegel approved these changes May 12, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 12, 2021

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12854 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12854 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17211

Test results coming soon (I hope)...

Details

- notification for comment with ID 840055680 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member

boegel commented May 12, 2021

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
node3506.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/a33b35c88097689d4f99ccf88d01e7a6 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 12, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/cc482db420ee846c9c6957b8843db7b8 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 12, 2021

Going in, thanks @ocaisa!

@boegel boegel merged commit 89f9c39 into easybuilders:develop May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

change

Projects

None yet

Milestone

4.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ocaisa @boegel @boegelbot @Micket