Skip to content

Add IceLake detection to OpenBLAS 0.3.12 and 0.3.15#12865

Merged
boegel merged 1 commit intoeasybuilders:developfrom
branfosj:20210515094128_new_pr_OpenBLAS0312
May 18, 2021
Merged

Add IceLake detection to OpenBLAS 0.3.12 and 0.3.15#12865
boegel merged 1 commit intoeasybuilders:developfrom
branfosj:20210515094128_new_pr_OpenBLAS0312

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented May 15, 2021 •
edited
Loading

(created using eb --new-pr)

This adds the upstream patch, which works for 0.3.12 and 0.3.15. Further changes are required for older OpenBLAS.

I've marked this as draft until I am able to test it on IceLake.

@branfosj branfosj added this to the next release (4.4.0) milestone May 15, 2021
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented May 15, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0211u08b.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/a38af0e9db59cf6cc1e73ecd52d2c54c for a full test report.

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented May 15, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bber0501u03a.bb2.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/14fb8faac8ef6971b05bb598c16af8c5 for a full test report.

@branfosj branfosj marked this pull request as draft May 15, 2021 08:56
boegel
boegel approved these changes May 15, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented May 17, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bask-pg0308u12a - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Platinum 8358P CPU @ 2.60GHz (icelake), Python 3.6.8
See https://gist.github.com/af54188070b7de04803aa7da82c91b98 for a full test report.

@branfosj branfosj marked this pull request as ready for review May 17, 2021 14:58
@boegel
Copy link
Copy Markdown
Member

boegel commented May 17, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 17, 2021

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12865 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12865 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17242

Test results coming soon (I hope)...

Details

- notification for comment with ID 842619310 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 17, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/c5160cc6a99615ea764d00c86735df0e for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 18, 2021

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3171.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/478c44b70642c1bb06f8048dc3d80482 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 18, 2021

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3412.kirlia.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz (cascadelake), Python 3.6.8
See https://gist.github.com/b59882f8a605a507eedd719952a5cdb1 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 18, 2021

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node2618.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/3e738a75050a0d14a3047f4fe3f0851c for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 18, 2021

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
select-pika-c6gd-2xlarge-0001 - Linux centos linux 8.3.2011, AArch64, ARM UNKNOWN (graviton2), Python 3.6.8
See https://gist.github.com/42808b83cac86ea1005da6236ea796a0 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 18, 2021

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
easybuild2.novalocal - Linux centos linux 8.3.2011, POWER, IBM pSeries (emulated by qemu) (power9le), Python 3.6.8
See https://gist.github.com/08413cefb5fbe8fe453cfc9d0844a0f8 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 18, 2021

Going in, thanks @branfosj!

@boegel boegel merged commit 365f94d into easybuilders:develop May 18, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented May 18, 2021

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3614.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/6df02b29317ff51846eb037ca8200112 for a full test report.

@branfosj branfosj deleted the 20210515094128_new_pr_OpenBLAS0312 branch May 18, 2021 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@branfosj @boegel @boegelbot