Skip to content

run 'make clean' before building FragGeneScan, to clean up object files included in source tarball#12870

Merged
branfosj merged 1 commit intoeasybuilders:developfrom
boegel:20210516180905_new_pr_FragGeneScan131
May 16, 2021
Merged

run 'make clean' before building FragGeneScan, to clean up object files included in source tarball#12870
branfosj merged 1 commit intoeasybuilders:developfrom
boegel:20210516180905_new_pr_FragGeneScan131

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented May 16, 2021 •
edited
Loading

(created using eb --new-pr)

This fixes build failures on non-x86_64 systems like:

gcc  -O2 -ftree-vectorize -mcpu=native -fno-math-errno -o FragGeneScan util_lib.o hmm_lib.o run_hmm.o  -lm -lpthread
/mnt/shared/home/boegel/software/binutils/2.31.1-GCCcore-8.2.0/bin/ld.gold: error: util_lib.o: incompatible target
/mnt/shared/home/boegel/software/binutils/2.31.1-GCCcore-8.2.0/bin/ld.gold: error: hmm_lib.o: incompatible target
/mnt/shared/home/boegel/software/binutils/2.31.1-GCCcore-8.2.0/bin/ld.gold: error: run_hmm.o: incompatible target
/lib/../lib64/crt1.o(.text+0x18): error: undefined reference to 'main'
/lib/../lib64/crt1.o(.text+0x1c): error: undefined reference to 'main'
/lib/../lib64/crt1.o(.text+0x20): error: undefined reference to 'main'
/lib/../lib64/crt1.o(.text+0x24): error: undefined reference to 'main'
collect2: error: ld returned 1 exit status
make: *** [Makefile:10: fgs] Error 1

@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 16, 2021

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3507.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/4f907a73ad317cb576de00a6a74e14be for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 16, 2021

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
gligar05.gastly.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/83986292375482832a8d925b9362351c for a full test report.

@boegel boegel added the bug fix label May 16, 2021
@boegel boegel added this to the next release (4.4.0) milestone May 16, 2021
@branfosj
Copy link
Copy Markdown
Member

branfosj commented May 16, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0211u08b.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/c1793196184e5ba1a25697eed887896e for a full test report.

branfosj
branfosj approved these changes May 16, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Copy Markdown
Member

branfosj commented May 16, 2021

Going in, thanks @boegel!

@branfosj branfosj merged commit e96be6a into easybuilders:develop May 16, 2021
@branfosj branfosj mentioned this pull request May 16, 2021
Merged
@boegel boegel deleted the 20210516180905_new_pr_FragGeneScan131 branch May 16, 2021 17:15
@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 16, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
easybuild2.novalocal - Linux centos linux 8.3.2011, POWER, IBM pSeries (emulated by qemu) (power9le), Python 3.6.8
See https://gist.github.com/f6690dfe42a1c86da4ff2ff6baf1e556 for a full test report.

@boegel boegel added the aarch64 Related to Arm 64-bit (aarch64) label May 16, 2021
@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 16, 2021

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
select-pika-c6gd-2xlarge-0002 - Linux centos linux 8.3.2011, AArch64, ARM UNKNOWN (graviton2), Python 3.6.8
See https://gist.github.com/9887f2d6d1cadaf189c9a7cbd4eee00e for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@branfosj branfosj branfosj approved these changes

Assignees

No one assigned

Labels

aarch64 Related to Arm 64-bit (aarch64) bug fix

Projects

None yet

Milestone

4.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @branfosj