dump easyconfig before initializing easyblock in order to compare it with original easyconfig#12925
Merged
branfosj merged 1 commit intoeasybuilders:developfrom May 21, 2021
Merged
Conversation
…with original easyconfig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is required because of the fix to
get_config_dictin easybuilders/easybuild-framework#3692 .The result of the fix is that
ec.parser.get_config_dict()now accurately reflects the original easyconfig file, whereas before the fix the value of mutable easyconfig parameters could have been tweaked by the easyblock constructor (likePythonBundledoes forexts_default_options).The easyconfig file that is dumped via
ec.dump()will still include the modified easyconfig parameter though, and hence the comparison between the original easyconfig file and the dumped easyconfig file failed for easyconfigs that use an easyblock likePythonBundlethat fiddles with easyconfig parameters at initialization.Note that the behavior of
dump()wasn't affected by the change in easybuilders/easybuild-framework#3692, but we're now (accurately) comparing the parsed dumped easyconfig with the actual original easyconfig parameter as defined in the easyconfig file.The fix here is to just dump the easyconfig file before the easyblock instance is created, so any tweaks done by the easyblock constructor to parameter values don't affect the value comparison for easyconfig parameters we want to do in the tests...