Skip to content

correct the patch and apply it earlier in the R-INLA install#12927

Merged
boegel merged 4 commits intoeasybuilders:developfrom
branfosj:20210521175723_new_pr_R-INLA210502
May 25, 2021
Merged

correct the patch and apply it earlier in the R-INLA install#12927
boegel merged 4 commits intoeasybuilders:developfrom
branfosj:20210521175723_new_pr_R-INLA210502

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented May 21, 2021

(created using eb --new-pr)

On a system with no rsync I get: /bin/bash: line 9: rsync: command not found during the install of fmesher. Testing shows that the R-INLA-21.05.02-skip-binaries.patch was being applied after this component was installed, so the patching out of rsync had no impact.

There is one issue though, which is why this is marked as a draft. As the patching happens earlier, GMRFLib file openmp.c gets INLA_LINK_WITH_OPENBLAS added before it is built. This is invalid c code and breaks the build. I do not know what this part of the patch was trying to do, so I've commented it out.

@branfosj branfosj added this to the 4.4.0 milestone May 21, 2021
@branfosj branfosj marked this pull request as draft May 21, 2021 17:07
@boegel
Copy link
Copy Markdown
Member

boegel commented May 22, 2021

@deniskristak @Darkless012 Can you clarify the INLA_LINK_WITH_OPENBLAS line in the patch? That looks like a mistake?

@deniskristak
Copy link
Copy Markdown
Contributor

@branfosj @boegel @Darkless012 it truly does look like a mistake..sorry for that, mustve left it there accidentaly

@branfosj
Copy link
Copy Markdown
Member Author

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux Ubuntu 20.04, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.8.5
See https://gist.github.com/53d0ec723c8fb82ed295ef399a15dfce for a full test report.

@branfosj branfosj marked this pull request as ready for review May 25, 2021 09:41
@branfosj
Copy link
Copy Markdown
Member Author

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0211u08b.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/da2433410ff654e7eba349e0506741ee for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 25, 2021

@boegelbot please test @ generoso

@boegel
Copy link
Copy Markdown
Member

boegel commented May 25, 2021

@branfosj @boegel @Darkless012 it truly does look like a mistake..sorry for that, mustve left it there accidentaly

@deniskristak Thanks for clarifying!

@branfosj
Copy link
Copy Markdown
Member Author

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux Ubuntu 20.04, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.8.5
See https://gist.github.com/53d0ec723c8fb82ed295ef399a15dfce for a full test report.

For reference: this test is from the system with no rsync.

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12927 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12927 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17303

Test results coming soon (I hope)...

Details

- notification for comment with ID 847721070 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/d87e4fa7a5f54afa45d03c4c33384f06 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 25, 2021

Going in, thanks @branfosj!

@boegel boegel merged commit a3fa0ab into easybuilders:develop May 25, 2021
@branfosj branfosj deleted the 20210521175723_new_pr_R-INLA210502 branch May 25, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants