{devel}[gcccuda/2020b] hipify-clang 4.2.0#12961
Conversation
`hipify-clang` is a clang-based tool for translating CUDA sources into HIP sources. It translates CUDA source into an abstract syntax tree, which is traversed by transformation matchers. After applying all the matchers, the output HIP source is produced.
| # NOTE: The following configuration options are needed if building with tests | ||
| # (as activated by 'runtest' below), for these to work the above commented | ||
| # dependencies need to be uncommented. Currently testing is disabled due to a | ||
| # lack of 'llvm-lit'. |
There was a problem hiding this comment.
What's llvm-lit exactly, do you have a link for that?
There was a problem hiding this comment.
I have not looked too much into this, but it is apparently LLVM's own test framework. It is built as a part of LLVM when testing is enabled.
| ] | ||
|
|
||
| configopts = '-DHIPIFY_CLANG_TESTS=0' | ||
| configopts += ' -DCMAKE_INSTALL_PREFIX=%(installdir)s' |
There was a problem hiding this comment.
This is added automatically by CMakeMake, should not be needed?
|
|
||
| configopts = '-DHIPIFY_CLANG_TESTS=0' | ||
| configopts += ' -DCMAKE_INSTALL_PREFIX=%(installdir)s' | ||
| configopts += ' -DCMAKE_PREFIX_PATH=$EBROOTCLANG' |
There was a problem hiding this comment.
Not required, set automatically and is even potentially harmful: We have set this as an env var and I'd need to look up if this overwrites (and hence removes) our stuff or not.
Anyway, this is already set so no need to do here :)
|
Made the requested changes |
| # ('Python', '3.8.6'), | ||
| ] | ||
|
|
||
| configopts = '-DHIPIFY_CLANG_TESTS=0' |
There was a problem hiding this comment.
As this is off by default, I think it makes sense to set it to 1 and comment it out next to the other test-related options below.
|
@boegelbot please test @ generoso |
|
@boegel: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 857756674 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
Test report by @boegel |
|
Test report by @boegel |
|
Going in, thanks @nordmoen! |
hipify-clangis a clang-based tool for translating CUDA sources into HIP sources.