in easyconfig tests, check version of dependencies named Python, not if dependencies with certain versions are named Python#12962
Merged
boegel merged 1 commit intoeasybuilders:developfrom May 26, 2021
Conversation
…ies with certain versions
boegel
approved these changes
May 26, 2021
Member
|
This certainly looks backwards to me, thanks for the fix @migueldiascosta! If you also want to filter out external modules from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is what was intended?
This showed up when testing #12863, which has an external module dependency with no version information, but I suppose
test_changed_files_pull_requestshould also filter out external modules, likeprocess_all_easyconfigsdoes?