Skip to content

add bare Python 3.9.5 easyconfig and use that as builddep for LLVM 11.1.0#13035

Merged
lexming merged 1 commit intoeasybuilders:developfrom
migueldiascosta:20210604155701_new_pr_Python395
Jun 5, 2021
Merged

add bare Python 3.9.5 easyconfig and use that as builddep for LLVM 11.1.0#13035
lexming merged 1 commit intoeasybuilders:developfrom
migueldiascosta:20210604155701_new_pr_Python395

Conversation

@migueldiascosta
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta commented Jun 4, 2021 •
edited
Loading

(created using eb --new-pr)

the full Python 3.9.5 is a pretty "heavy" builddep, particularly now that it requires Rust, which builds it's own LLVM...

this seems to make more sense (?)

migueldiascosta
migueldiascosta commented Jun 4, 2021
View reviewed changes
Comment thread easybuild/easyconfigs/p/Python/Python-3.9.5-GCCcore-10.3.0-bare.eb
('ncurses', '6.2'),
('SQLite', '3.35.4'),
('XZ', '5.2.5'),
('libffi', '3.3'),
Copy link
Copy Markdown
Member Author

@migueldiascosta migueldiascosta Jun 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the # required for cryptography comment in the full Python easyconfigs is now misleading, libffi is now also required to build Python itself - Python used to bundle libffi, but not anymore (since 3.7?)

Copy link
Copy Markdown
Member

@boegel boegel Jun 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we should tweak the comment there to reflect that (best in a separate PR)?

Copy link
Copy Markdown
Member Author

@migueldiascosta migueldiascosta Jun 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed the change was on 3.7.0, will do

Copy link
Copy Markdown
Member Author

@migueldiascosta migueldiascosta Jun 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#13041

@migueldiascosta
Copy link
Copy Markdown
Member Author

migueldiascosta commented Jun 4, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 4, 2021

@migueldiascosta: Request for testing this PR well received on generoso

PR test command 'EB_PR=13035 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_13035 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17349

Test results coming soon (I hope)...

Details

- notification for comment with ID 854473314 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 4, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/316376b7165ed9aa799060a0bd14f298 for a full test report.

@boegel boegel added this to the next release (4.4.1) milestone Jun 4, 2021
@boegel boegel added the change label Jun 4, 2021
boegel
boegel approved these changes Jun 4, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 4, 2021

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node2617.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/925e66c7b8cf2cf73ac3f78fbdf8a0e1 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 4, 2021

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3526.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/a31975e4795c7c7fd62d7c8825ca0543 for a full test report.

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Jun 5, 2021

Test report by @lexming
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node376.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/789f5718ce720b816f91c9f2684b942a for a full test report.

lexming
lexming approved these changes Jun 5, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Jun 5, 2021

Going in, thanks @migueldiascosta !

@lexming lexming merged commit 206394d into easybuilders:develop Jun 5, 2021
@migueldiascosta migueldiascosta mentioned this pull request Jun 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

@lexming lexming lexming approved these changes

Assignees

No one assigned

Labels

change update

Projects

None yet

Milestone

4.4.1

Development

Successfully merging this pull request may close these issues.

4 participants

@migueldiascosta @boegelbot @boegel @lexming