fix mpi4py source_urls in Python easyconfigs#1306
Merged
boegel merged 1 commit intoeasybuilders:developfrom Jan 15, 2015
Merged
fix mpi4py source_urls in Python easyconfigs#1306boegel merged 1 commit intoeasybuilders:developfrom
boegel merged 1 commit intoeasybuilders:developfrom
Conversation
Member
|
looks fine, only 1 remark: use |
Member
Author
|
actually, I don't think that trick works for extensions... |
|
Test PASSed. |
Member
Author
|
@wpoely86: doesn't work (yet): == 2015-01-15 22:49:28,075 main.filetools DEBUG Trying to download mpi4py-1.3.1.tar.gz from http://bitbucket.org/%(namelower)s/%(namelower)s/downloads/mpi4py-1.3.1.tar.gz to /Users/kehoste/.local/easybuild/sources/p/Python/extensions/mpi4py-1.3.1.tar.gz |
Member
Author
|
opened easybuilders/easybuild-framework#1138, not blocking this PR because of that |
Member
Author
|
Thanks for the review @wpoely86! |
boegel
added a commit
that referenced
this pull request
Jan 15, 2015
fix mpi4py source_urls in Python easyconfigs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes remark made by @wpoely86 in #1291