Skip to content

{bio}[GCC/9.3.0] RAPSearch2 v2.24#13199

Merged
verdurin merged 5 commits intoeasybuilders:developfrom
DeepThoughtHPC:20210618001827_new_pr_RAPSearch2224
Dec 14, 2021
Merged

{bio}[GCC/9.3.0] RAPSearch2 v2.24#13199
verdurin merged 5 commits intoeasybuilders:developfrom
DeepThoughtHPC:20210618001827_new_pr_RAPSearch2224

Conversation

@manifestoso
Copy link
Copy Markdown
Contributor

@manifestoso manifestoso commented Jun 17, 2021

(created using eb --new-pr)

@Micket Micket added the new label Jun 21, 2021
@Micket Micket added this to the 4.x milestone Jun 21, 2021
Micket
Micket approved these changes Jun 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Jun 21, 2021

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis-c1 - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/42cc85df9dd54f07f69cbfe9e2feccdb for a full test report.

Micket
Micket previously requested changes Jun 21, 2021
View reviewed changes
Comment thread easybuild/easyconfigs/r/RAPSearch2/RAPSearch2-2.24-GCC-9.3.0.eb Outdated
sources = ['%(name)s.24_64bits.tar.gz']
checksums = ['85db4573f4c768b6c3c73bb44ff2611ba48dc6c8d188feb40f44bf7c55de36ce']

install_cmd = './install'
Copy link
Copy Markdown
Contributor

@Micket Micket Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I don't think this is called at all here at all (perhaps it's not used when you specify files to copy)? I doesn't build anything, and you are just copying the prebuilt binaries. This actually depends on boost, so it wouldn't build without it.
I think you want build_cmd here (despite the name of this script "install", it actually just builds)

@manifestoso
Copy link
Copy Markdown
Contributor Author

manifestoso commented Jun 25, 2021

Actually, I don't think this is called at all here at all (perhaps it's not used when you specify files to copy)? I doesn't build anything, and you are just copying the prebuilt binaries. This actually depends on boost, so it wouldn't build without it.
I think you want build_cmd here (despite the name of this script "install", it actually just builds)

Good catch, MakeCp seems a better block for this. Thx @Micket,

manifestoso and others added 2 commits June 25, 2021 17:35
@manifestoso
easyblock change
27165fa
Delete RAPSearch2-2.24-GCC-9.3.0.eb
0e14459 
Change to lagacy toolchange for compilation.
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jun 25, 2021

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
easybuild-c7.novalocal - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/4ac8365efae9c25dbfdcacb1278d1ee8 for a full test report.

verdurin
verdurin requested changes Jun 25, 2021
View reviewed changes
Comment thread easybuild/easyconfigs/r/RAPSearch2/RAPSearch2-2.24.eb Outdated
@manifestoso
Copy link
Copy Markdown
Contributor Author

manifestoso commented Jul 1, 2021

Wait, why was this moved to system level at all? We are definitely compiling stuff here, the previous use of GCC-9.3.0 was definitely the correct choice.

Hmm, distribution tarball includes a legacy boost which is only compatible with legacy gcc 4.8.5
I guess we can try to link a modern boost but I prefer to use the distributed code as much as possible. See what you think @Micket

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Jul 1, 2021

There is no guarantee that the OS will have such an ancient compiler

@manifestoso
Copy link
Copy Markdown
Contributor Author

manifestoso commented Jul 1, 2021

There is no guarantee that the OS will have such an ancient compiler

That's true but as OS up to RHEL 7.9, gcc 4.8.x is available, maybe a note prompt in the header for the time being and wait until next software update? @Micket

@manifestoso
Copy link
Copy Markdown
Contributor Author

manifestoso commented Nov 4, 2021

@verdurin @Micket @smoors can we merge this PR.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Nov 4, 2021

@robqiao Please add some way of addressing the comment about compiler compatibility, so we can make a decision.

@manifestoso
Copy link
Copy Markdown
Contributor Author

manifestoso commented Nov 5, 2021 •
edited
Loading

@robqiao Please add some way of addressing the comment about compiler compatibility, so we can make a decision.

@verdurin
Done. The compiler issue was caused by GCC-4.9.x to GCC-5.2.x hard upgrades, i.e. GCC-4.9.x was not fully c++11 complied. Now switched to c++11 string compatible ABI. Case closed.

@manifestoso
Copy link
Copy Markdown
Contributor Author

manifestoso commented Nov 10, 2021 •
edited
Loading

@Micket @verdurin check this PR, thx?

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Nov 11, 2021

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
easybuild-c7.novalocal - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/00143bad6e393b244d780c6bcd821ced for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Nov 11, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 11, 2021

@verdurin: Request for testing this PR well received on login1

PR test command 'EB_PR=13199 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_13199 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7256

Test results coming soon (I hope)...

Details

- notification for comment with ID 966207061 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 11, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cnx1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/dd34004c8745d2e6b45f693c9118243b for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Nov 11, 2021

@Micket I'm happy with this one now.

@Micket Micket dismissed their stale review November 11, 2021 11:16

Leaving this to @verdurin

@manifestoso manifestoso requested a review from verdurin December 12, 2021 22:14
@manifestoso
Copy link
Copy Markdown
Contributor Author

manifestoso commented Dec 14, 2021

Finish this PR @smoors?

@verdurin verdurin modified the milestones: 4.x, next release (4.5.2?) Dec 14, 2021
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Dec 14, 2021

Going in, thanks @manifestoso!

@verdurin verdurin merged commit d751eca into easybuilders:develop Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Awaiting requested review from Micket

@verdurin verdurin Awaiting requested review from verdurin

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.5.2

Development

Successfully merging this pull request may close these issues.

4 participants

@manifestoso @Micket @verdurin @boegelbot