Skip to content

disable own avx detection of libfabric v1.12.1#13215

Merged
boegel merged 1 commit intoeasybuilders:developfrom
lexming:20210619004045_new_pr_libfabric1121
Jun 19, 2021
Merged

disable own avx detection of libfabric v1.12.1#13215
boegel merged 1 commit intoeasybuilders:developfrom
lexming:20210619004045_new_pr_libfabric1121

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented Jun 18, 2021 •
edited
Loading

(created using eb --new-pr)

The configure script of psm3 has its own logic to determine if the system has AVX. However, it does not check the actual capabilities of the CPU which can result in broken binaries at the end of the build. For instance AVX2 binaries on Intel IvyBridge system. This PR disables those checks as those settings are already defined by EasyBuild.

This PR also adds a missing dependency on numactl.

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Jun 18, 2021

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node106.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz, Python 2.7.5
See https://gist.github.com/57eebc8c172553d6084166d781e158bc for a full test report.

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Jun 18, 2021

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node381.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/1ef170968b0f2ab8e892f4b4a955ce50 for a full test report.

Micket
Micket approved these changes Jun 18, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Jun 18, 2021

@boegelbot please test @ generoso

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Jun 18, 2021

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis-c1 - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/210587009cf84fd393515624e9bd5f79 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 18, 2021

@Micket: Request for testing this PR well received on generoso

PR test command 'EB_PR=13215 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_13215 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17577

Test results coming soon (I hope)...

Details

- notification for comment with ID 864314476 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 18, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-x-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/5ee13437c3b55007b75876e5ae730fdf for a full test report.

@Micket Micket added this to the next release (4.4.1) milestone Jun 18, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 19, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2618.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/5d469ee8aab28ef7579af93351547f3e for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 19, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
easybuild2.novalocal - Linux centos linux 8.3.2011, POWER, IBM pSeries (emulated by qemu) (power9le), Python 3.6.8
See https://gist.github.com/c506c6b06cd10a6c7cfe689ee7e8a50b for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 19, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
select-pika-c6gd-2xlarge-0001 - Linux centos linux 8.3.2011, AArch64, ARM UNKNOWN (graviton2), Python 3.6.8
See https://gist.github.com/41edac883bf1f4e92a59d97cd2d3df1b for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 19, 2021

Going in, thanks @lexming!

@boegel boegel merged commit 6d4eab0 into easybuilders:develop Jun 19, 2021
@lexming lexming deleted the 20210619004045_new_pr_libfabric1121 branch June 19, 2021 11:34
@branfosj branfosj mentioned this pull request Aug 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.4.1

Development

Successfully merging this pull request may close these issues.

4 participants

@lexming @Micket @boegelbot @boegel