Skip to content

add patch to fix installation of TensorFlow 2.0.x#13248

Merged
boegel merged 3 commits intoeasybuilders:developfrom
Flamefire:20210623154834_new_pr_TensorFlow200
Jun 24, 2021
Merged

add patch to fix installation of TensorFlow 2.0.x#13248
boegel merged 3 commits intoeasybuilders:developfrom
Flamefire:20210623154834_new_pr_TensorFlow200

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Jun 23, 2021

(created using eb --new-pr)

Micket
Micket previously approved these changes Jun 23, 2021
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket added the bug fix label Jun 23, 2021
@Micket Micket added this to the next release (4.4.1) milestone Jun 23, 2021
Micket
Micket previously approved these changes Jun 23, 2021
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Jun 23, 2021

Test report by @Micket
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2469
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in total)
vera54-1 - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz, Python 3.6.8
See https://gist.github.com/ea866d263e437f2091846d20c2d4979c for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Jun 23, 2021

No idea why the 2019a version failed. at least it installs, but then I hit

== 2021-06-23 22:14:49,811 run.py:226 INFO running cmd: python -c "import google.protobuf"
== 2021-06-23 22:14:50,002 extensioneasyblock.py:181 INFO Sanity check for protobuf successful!
...
== 2021-06-23 22:14:58,315 run.py:226 INFO running cmd: python -c "import tensorflow_estimator"
== 2021-06-23 22:14:58,590 extension.py:218 WARNING Sanity check for 'tensorflow-estimator' extension failed: command "python -c "import tensorflow_estimator"" failed; output:
Traceback (most recent call last):
  File "/apps/Vera/software/TensorFlow/2.0.0-foss-2019a-Python-3.7.2/lib/python3.7/site-packages/tensorflow_core/python/pywrap_tensorflow.py", line 58, in <module>
    from tensorflow.python.pywrap_tensorflow_internal import *
  File "/apps/Vera/software/TensorFlow/2.0.0-foss-2019a-Python-3.7.2/lib/python3.7/site-packages/tensorflow_core/python/pywrap_tensorflow_internal.py", line 28, in <module>
    _pywrap_tensorflow_internal = swig_import_helper()
  File "/apps/Vera/software/TensorFlow/2.0.0-foss-2019a-Python-3.7.2/lib/python3.7/site-packages/tensorflow_core/python/pywrap_tensorflow_internal.py", line 24, in swig_import_helper
    _mod = imp.load_module('_pywrap_tensorflow_internal', fp, pathname, description)
  File "/apps/Vera/software/Python/3.7.2-GCCcore-8.2.0/lib/python3.7/imp.py", line 242, in load_module
    return load_dynamic(name, filename, file)
  File "/apps/Vera/software/Python/3.7.2-GCCcore-8.2.0/lib/python3.7/imp.py", line 342, in load_dynamic
    return _load(spec)
ImportError: libprotobuf.so.3.7.1.0: cannot open shared object file: No such file or directory

@Flamefire
Copy link
Copy Markdown
Contributor Author

Test report by @Flamefire
FAILED
Build succeeded for 3 out of 5 (4 easyconfigs in total)
taurusa4 - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2603 v4 @ 1.70GHz (broadwell), Python 2.7.5
See https://gist.github.com/6fe36ade96d4047e5a9fdaa959d4b8ca for a full test report.

@Flamefire
Copy link
Copy Markdown
Contributor Author

Test report by @Flamefire
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2469
FAILED
Build succeeded for 3 out of 5 (4 easyconfigs in total)
taurusa5 - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2603 v4 @ 1.70GHz (broadwell), Python 2.7.5
See https://gist.github.com/e624e38473481e63c990c320f2c59013 for a full test report.

@boegel boegel changed the title Fix TensorFlow 2.0 builds add patch to fix installation of TensorFlow 2.0.x Jun 24, 2021
@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 24, 2021

@boegelbot please test @ generoso
EB_ARGS="--include-easyblocks-from-pr 2469"
CORE_CNT=16

@Flamefire
Copy link
Copy Markdown
Contributor Author

I'm not fully sure why this wasn't caught before but I think the TF_SYSTEM_LIB things were introduced AFTER 2.0.0 and all the tested ECs used protobuf-python as runtime dep which has protobuf as a dep so the issue was hidden.
Fixed. Reports coming up.
@boegel You might want to restart your tests

@easybuilders easybuilders deleted a comment from boegelbot Jun 24, 2021
@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=13248 EB_ARGS="--include-easyblocks-from-pr 2469" /apps/slurm/default/bin/sbatch --job-name test_PR_13248 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17617

Test results coming soon (I hope)...

Details

- notification for comment with ID 867386736 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 24, 2021

Test report by @boegel
SUCCESS
Build succeeded for 8 out of 8 (4 easyconfigs in total)
node3302.joltik.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6242 CPU @ 2.80GHz (cascadelake), Python 3.6.8
See https://gist.github.com/8ab91863cd850a7783a366cf10dbae58 for a full test report.

Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 24, 2021

Test report by @boegel
SUCCESS
Build succeeded for 11 out of 11 (4 easyconfigs in total)
node3120.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/acd414ad13ea034061c0a60e7e63098f for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2469
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
generoso-x-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/319b0c7139e01e2ca0b4737ecf292b02 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 24, 2021

Going in, thanks @Flamefire!

@boegel boegel merged commit 65ed557 into easybuilders:develop Jun 24, 2021
@Flamefire Flamefire deleted the 20210623154834_new_pr_TensorFlow200 branch June 25, 2021 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants