{tools} [intel-2015a] multitail-6.2.1 (REVIEW) by wpoely86 · Pull Request #1327 · easybuilders/easybuild-easyconfigs

wpoely86 · 2015-01-23T13:54:16Z

No description provided.

wpoely86 · 2015-01-23T14:01:35Z

@boegel any reason why we don't enable the UTF-8 version of ncurses? ( --enable-widec )

hpcugentbot · 2015-01-23T14:01:42Z

Test PASSed.

hpcugentbot · 2015-01-23T14:08:36Z

Test PASSed.

boegel · 2015-01-23T16:04:45Z

if you do it like this, the -O2 that's there is going to win over whatever -Ox eb sets, so please include the $(CFLAGS) after -O2

boegel · 2015-01-23T16:10:07Z

@wpoely86: I can't think of a reason no to enable UTF-8 in ncurses... not sure if it'll break something 'upstream' (i.e. stuff that depends on it)

wpoely86 · 2015-01-23T16:11:08Z

@boegel It's split up in a separate library (libncursesw), so it should give any trouble.

wpoely86 · 2015-01-23T16:12:00Z

Test report by @wpoely86
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in this PR)
Linux debian 7.8, Intel(R) Xeon(R) CPU 5130 @ 2.00GHz, Python 2.7.3
See https://gist.github.com/4fb76f90f9422b10a4ec for a full test report.

wpoely86 · 2015-01-23T16:16:19Z

Test report by @wpoely86
FAILED
Build succeeded for 0 out of 2 (2 easyconfigs in this PR)
Linux debian 7.8, Intel(R) Xeon(R) CPU 5130 @ 2.00GHz, Python 2.7.3
See https://gist.github.com/4b4df01b982ab3d34db3 for a full test report.

boegel · 2015-01-23T16:17:19Z

shouldn't we do this in a separate PR (in all ncurses easyconfigs?)

first test it here. Then do the rest?

I'd open a dedicated PR for this, rather than fiddling around in a PR that worked fine without this...

You can start with only touched a single ncurses in the PR, and expand as you go.

no, this PR does not work fine without it. It is needed.

OK, then it makes sense to tackle it here for this ncurses easyconfig, and sync up the others in a dedicated PR.

boegel · 2015-01-23T16:17:49Z

@wpoely86: you broke it ;)

wpoely86 · 2015-01-23T16:38:05Z

Test report by @wpoely86
FAILED
Build succeeded for 0 out of 2 (2 easyconfigs in this PR)
Linux debian 7.8, Intel(R) Xeon(R) CPU 5130 @ 2.00GHz, Python 2.7.3
See https://gist.github.com/e1a2be1e331d2e9adbab for a full test report.

hpcugentbot · 2015-01-23T16:50:04Z

Test PASSed.

wpoely86 · 2015-01-23T16:57:52Z

Test report by @wpoely86
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in this PR)
Linux debian 7.8, Intel(R) Xeon(R) CPU 5130 @ 2.00GHz, Python 2.7.3
See https://gist.github.com/07e28c3ccdc593c32998 for a full test report.

hpcugentbot · 2015-01-23T17:06:22Z

Test PASSed.

boegel · 2015-01-23T17:48:53Z

@wpoely86: closing in...

wpoely86 · 2015-01-23T17:50:51Z

@boegel needs more work. On most distro's, the includes are split up: one directory include/ncurses for the regular version and one include/ncursesw for the utf-8 version. This currently both puts them in include. I'm gonna patch the makefile.

boegel · 2015-01-23T22:31:10Z

@wpoely86: it patching the Makefile how distros handle this?

wpoely86 · 2015-01-24T12:56:45Z

Test report by @wpoely86
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in this PR)
Linux debian 7.8, Intel(R) Xeon(R) CPU 5130 @ 2.00GHz, Python 2.7.3
See https://gist.github.com/eb2ad88f1e7cbac90bde for a full test report.

hpcugentbot · 2015-01-24T13:03:24Z

Test PASSed.

wpoely86 · 2015-01-24T13:13:43Z

Test report by @wpoely86
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in this PR)
Linux debian 7.8, Intel(R) Xeon(R) CPU 5130 @ 2.00GHz, Python 2.7.3
See https://gist.github.com/f7fa1ca74314f3a01489 for a full test report.

wpoely86 · 2015-01-24T13:20:28Z

Test report by @wpoely86
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
Linux debian 7.8, Intel(R) Xeon(R) CPU 5130 @ 2.00GHz, Python 2.7.3
See https://gist.github.com/f3636edb9971324aa0db for a full test report.

wpoely86 · 2015-01-24T13:20:49Z

at least! @boegel will give this a spin too?

hpcugentbot · 2015-01-24T13:22:50Z

Test PASSed.

boegel · 2015-01-26T13:38:16Z

align comments with the string they apply to please

wpoely86 · 2015-01-26T14:12:08Z

@boegel fixed

hpcugentbot · 2015-01-26T14:20:51Z

Test PASSed.

boegel · 2015-01-26T19:17:38Z

@wpoely86: I'd like to see a separate PR for syncing the other ncurses easyconfigs with the one in here, before we merge this in... Are you up for that? You can leave the full test report up to me, submitting one for just a couple of easyconfigs you touch is fine by me.

boegel · 2015-01-26T19:25:44Z

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
Linux SL 6.5, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/e0973cdcf629248e8281 for a full test report.

wpoely86 · 2015-01-26T19:26:47Z

@boegel ok, will issue PR for ncursesw.

boegel · 2015-01-26T19:54:59Z

PR for others ncurses easyconfigs is in #1337, this one is good to go in, thanks @wpoely86!

{tools} [intel-2015a] multitail-6.2.1 (REVIEW)

wpoely86 added 3 commits January 23, 2015 14:52

added multitail

a75b92a

Added: sanity check to mulitail

440de00

Added note to patch

57bf449

boegel reviewed Jan 23, 2015
View reviewed changes

Fix remarks for multitail

8a5b01d

Enable UTF-8 in ncurses

ff9fb73

boegel reviewed Jan 23, 2015
View reviewed changes

Build libncurses and libncursesw

b6f3c16

Another try for ncursesw

26bb72a

drop pkg-config in ncurses

45f3833

wpoely86 changed the title ~~{tools} [intel-2015a] multitail-6.2.1 (WIP)~~ {tools} [intel-2015a] multitail-6.2.1 (REVIEW) Jan 24, 2015

boegel reviewed Jan 26, 2015
View reviewed changes

Fix remarks

37efae0

wpoely86 mentioned this pull request Jan 26, 2015

{devel} [all of them, yes, ALL of them] enable ncursesw in all ncurses easyconfigs (REVIEW) #1337

Merged

boegel added a commit that referenced this pull request Jan 26, 2015

Merge pull request #1327 from wpoely86/multitail

6bf0250

{tools} [intel-2015a] multitail-6.2.1 (REVIEW)

boegel merged commit 6bf0250 into easybuilders:develop Jan 26, 2015

wpoely86 deleted the multitail branch January 26, 2015 19:59

Conversation

wpoely86 commented Jan 23, 2015

Uh oh!

wpoely86 commented Jan 23, 2015

Uh oh!

hpcugentbot commented Jan 23, 2015

Uh oh!

hpcugentbot commented Jan 23, 2015

Uh oh!

boegel Jan 23, 2015

Choose a reason for hiding this comment

Uh oh!

boegel commented Jan 23, 2015

Uh oh!

wpoely86 commented Jan 23, 2015

Uh oh!

wpoely86 commented Jan 23, 2015

Uh oh!

wpoely86 commented Jan 23, 2015

Uh oh!

boegel Jan 23, 2015

Choose a reason for hiding this comment

Uh oh!

wpoely86 Jan 23, 2015

Choose a reason for hiding this comment

Uh oh!

boegel Jan 23, 2015

Choose a reason for hiding this comment

Uh oh!

wpoely86 Jan 23, 2015

Choose a reason for hiding this comment

Uh oh!

boegel Jan 23, 2015

Choose a reason for hiding this comment

Uh oh!

boegel commented Jan 23, 2015

Uh oh!

wpoely86 commented Jan 23, 2015

Uh oh!

hpcugentbot commented Jan 23, 2015

Uh oh!

wpoely86 commented Jan 23, 2015

Uh oh!

hpcugentbot commented Jan 23, 2015

Uh oh!

boegel commented Jan 23, 2015

Uh oh!

wpoely86 commented Jan 23, 2015

Uh oh!

boegel commented Jan 23, 2015

Uh oh!

wpoely86 commented Jan 24, 2015

Uh oh!

hpcugentbot commented Jan 24, 2015

Uh oh!

wpoely86 commented Jan 24, 2015

Uh oh!

wpoely86 commented Jan 24, 2015

Uh oh!

wpoely86 commented Jan 24, 2015

Uh oh!

hpcugentbot commented Jan 24, 2015

Uh oh!

boegel Jan 26, 2015

Choose a reason for hiding this comment

Uh oh!

wpoely86 commented Jan 26, 2015

Uh oh!

hpcugentbot commented Jan 26, 2015

Uh oh!

boegel commented Jan 26, 2015

Uh oh!

boegel commented Jan 26, 2015

Uh oh!

wpoely86 commented Jan 26, 2015

Uh oh!

boegel commented Jan 26, 2015

Uh oh!

Reviewers

Assignees