Skip to content

add twang + xgboost extensions to recent R easyconfigs#13284

Merged
branfosj merged 1 commit intoeasybuilders:developfrom
boegel:20210629152742_new_pr_R403
Jul 2, 2021
Merged

add twang + xgboost extensions to recent R easyconfigs#13284
branfosj merged 1 commit intoeasybuilders:developfrom
boegel:20210629152742_new_pr_R403

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jun 29, 2021

(created using eb --new-pr)

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 29, 2021

@boegelbot please test @ generoso
EB_ARGS="R-4.0.3-foss-2020b.eb R-4.0.4-foss-2020b.eb R-4.0.5-foss-2020b.eb R-4.1.0-foss-2021a.eb --skip"

@boegel boegel added this to the next release (4.4.1) milestone Jun 29, 2021
@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=13284 EB_ARGS="R-4.0.3-foss-2020b.eb R-4.0.4-foss-2020b.eb R-4.0.5-foss-2020b.eb R-4.1.0-foss-2021a.eb --skip" /apps/slurm/default/bin/sbatch --job-name test_PR_13284 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17642

Test results coming soon (I hope)...

Details

- notification for comment with ID 870715772 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 29, 2021

Test report by @boegel
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
node3301.joltik.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6242 CPU @ 2.80GHz (cascadelake), Python 3.6.8
See https://gist.github.com/32cc8611e324581e2a19f7c4b24a5293 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

An older version of xgboost is in R-bundle-Bioconductor-3.12-foss-2020b-R-4.0.3.eb. I'm unsure what will happen if we load that module as well.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 29, 2021

An older version of xgboost is in R-bundle-Bioconductor-3.12-foss-2020b-R-4.0.3.eb. I'm unsure what will happen if we load that module as well.

First "hit" wins probably, so if R-bundle-Bioconductor is loaded, then the xgboost included there will be picked up.

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
generoso-x-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/d281c679ebb2886f1a7188d505fe0e74 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Jul 2, 2021

An older version of xgboost is in R-bundle-Bioconductor-3.12-foss-2020b-R-4.0.3.eb. I'm unsure what will happen if we load that module as well.

First "hit" wins probably, so if R-bundle-Bioconductor is loaded, then the xgboost included there will be picked up.

The twang cran page (https://cran.r-project.org/web/packages/twang/index.html) does not suggest there is a version requirement on xgboost - so we will likely be fine if someone has both loaded at the same time.

Copy link
Copy Markdown
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Jul 2, 2021

Going in, thanks @boegel!

@branfosj branfosj merged commit 1b2c824 into easybuilders:develop Jul 2, 2021
@boegel boegel deleted the 20210629152742_new_pr_R403 branch July 2, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants