Skip to content

fix recent taxator-tk easyconfigs by adding (back) -DBoost_NO_BOOST_CMAKE=ON configure option#13342

Merged
branfosj merged 1 commit intoeasybuilders:4.4.xfrom
boegel:fix_taxator-tk_boost_cmake
Jul 5, 2021
Merged

fix recent taxator-tk easyconfigs by adding (back) -DBoost_NO_BOOST_CMAKE=ON configure option#13342
branfosj merged 1 commit intoeasybuilders:4.4.xfrom
boegel:fix_taxator-tk_boost_cmake

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jul 5, 2021

This is required because of the changes made in

Without it, these two taxator-tk easyconfigs fail at configure time with:

CMake Warning (dev) at /software/Boost/1.74.0-GCC-10.2.0/lib64/cmake/Boost-1.74.0/BoostConfig.cmake:240 (if):
  Policy CMP0057 is not set: Support new IN_LIST if() operator.  Run "cmake
  --help-policy CMP0057" for policy details.  Use the cmake_policy command to
  set the policy and suppress this warning.

  IN_LIST will be interpreted as an operator when the policy is set to NEW.
  Since the policy is not set the OLD behavior will be used.
Call Stack (most recent call first):
  cmake-modules/FindBoost.cmake:206 (find_package)
  CMakeLists.txt:16 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Error at /software/Boost/1.74.0-GCC-10.2.0/lib64/cmake/Boost-1.74.0/BoostConfig.cmake:240 (if):
  if given arguments:

    "ALL" "IN_LIST" "Boost_FIND_COMPONENTS"

  Unknown arguments specified
Call Stack (most recent call first):
  cmake-modules/FindBoost.cmake:206 (find_package)
  CMakeLists.txt:16 (find_package)

With it, we get this back and the installation works fine:

-- Boost version: 1.74.0
-- Found the following Boost libraries:
--   program_options
--   system
--   filesystem
--   thread
-- Configuring done

Interestingly enough, taxator-tk-1.3.3-foss-2018b.eb still works fine, -DBoost_NO_BOOST_CMAKE=ON is not needed there, which suggests a bug in recent versions of Boost and/or CMake...

@boegel boegel added the bug fix label Jul 5, 2021
@boegel boegel added this to the next release (4.4.1) milestone Jul 5, 2021
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jul 5, 2021

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3701.slaking.os - Linux RHEL 8.2, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 3.6.8
See https://gist.github.com/20d7a62f057fc5b2a647c98ec3049180 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jul 5, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 5, 2021

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=13342 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_13342 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17710

Test results coming soon (I hope)...

Details

- notification for comment with ID 874220150 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 5, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
generoso-x-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/b1f84090810b34f912e64fb451258286 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jul 5, 2021

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node2654.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/10898186d14592e3e9267c555d2e6a1b for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Jul 5, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0211u08b.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/2da7291e973cfef09318df3e1c92823e for a full test report.

branfosj
branfosj approved these changes Jul 5, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Jul 5, 2021

Going in, thanks @boegel!

@branfosj branfosj merged commit 5167c03 into easybuilders:4.4.x Jul 5, 2021
@boegel boegel deleted the fix_taxator-tk_boost_cmake branch July 5, 2021 17:42
boegel added a commit that referenced this pull request Jul 5, 2021
@boegel
include #13342 in release notes for EasyBuild v4.4.1
d56ee04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@branfosj branfosj branfosj approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.4.1

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @branfosj