Skip to content

Fix order of cffi extension in old Python easyconfigs#13400

Merged
Micket merged 6 commits intoeasybuilders:developfrom
Flamefire:20210709115343_new_pr_Python363
Jul 14, 2021
Merged

Fix order of cffi extension in old Python easyconfigs#13400
Micket merged 6 commits intoeasybuilders:developfrom
Flamefire:20210709115343_new_pr_Python363

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Jul 9, 2021 •
edited
Loading

(created using eb --new-pr)

cryptography requires cffi and hence fails to install otherwise

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Jul 12, 2021

Test report by @Flamefire
FAILED
Build succeeded for 2 out of 12 (3 easyconfigs in total)
taurusa4 - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2603 v4 @ 1.70GHz (broadwell), Python 2.7.5
See https://gist.github.com/7b0cb9f69344eaca66545ec3edd2af56 for a full test report.

@Micket Micket added the bug fix label Jul 12, 2021
@Micket Micket added this to the next release (4.4.2?) milestone Jul 12, 2021
Micket
Micket previously approved these changes Jul 12, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Jul 12, 2021

You seem to be having license issues. Not sure I can easily provide test reports for those old intel versions either

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Jul 13, 2021

You seem to be having license issues. Not sure I can easily provide test reports for those old intel versions either

True. Already filtered out the older ones but missed intelcuda as the name. As the change is the same I'd say keep it. No idea how to get the new licenses working for 2017...

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Jul 13, 2021

Test report by @Flamefire
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
taurusa4 - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2603 v4 @ 1.70GHz (broadwell), Python 2.7.5
See https://gist.github.com/81241b5f1002468ca9a4676be3aa389f for a full test report.

@Flamefire Flamefire requested a review from Micket July 13, 2021 16:02
@Micket
Copy link
Copy Markdown
Contributor

Micket commented Jul 13, 2021

Test report by @Micket
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
alvis-c1 - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/6fa2f104419311c329703f890b7e3f30 for a full test report.

Micket
Micket approved these changes Jul 13, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Jul 14, 2021

Test report by @Micket
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in total)
alvis-c1 - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/e1d4d7b41c7df262f3b6afb95b895e52 for a full test report.

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Jul 14, 2021

@Micket Build failure looks unrelated to this change. Some options set somewhere maybe? See https://stackoverflow.com/questions/27290086/gcc-canaries-undefined-reference-to-stack-chk-guard

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Jul 14, 2021

Test report by @Micket
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
alvis-c1 - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/3c6b82c35d669391aa7534328bf55b06 for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Jul 14, 2021 •
edited
Loading

I'm not sure what happened to those 2 easyconfigs. They took forever to build, and, basically 0 load on the build node as well. I suspect filesystem issues. Retrying them
Edit: Actually, screw it. It's not related to this PR. I'm going ahead.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Jul 14, 2021

Going in, thanks @Flamefire!

@Micket Micket merged commit 0251d78 into easybuilders:develop Jul 14, 2021
@Flamefire Flamefire deleted the 20210709115343_new_pr_Python363 branch July 14, 2021 11:29
@boegel boegel changed the title Fix order of cffi in Python ECs Fix order of cffi extension in old Python easyconfigs Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.4.2

Development

Successfully merging this pull request may close these issues.

2 participants

@Flamefire @Micket