Skip to content

add missing Bio-Search-hmmer dependency for prokka#13419

Merged
smoors merged 3 commits intoeasybuilders:developfrom
hajgato:prokka
Jul 16, 2021
Merged

add missing Bio-Search-hmmer dependency for prokka#13419
smoors merged 3 commits intoeasybuilders:developfrom
hajgato:prokka

Conversation

@hajgato
Copy link
Copy Markdown
Collaborator

@hajgato hajgato commented Jul 13, 2021

No description provided.

@Micket Micket added the new label Jul 14, 2021
@Micket Micket added this to the next release (4.4.2?) milestone Jul 14, 2021
Micket
Micket approved these changes Jul 14, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Jul 14, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 14, 2021

@Micket: Request for testing this PR well received on generoso

PR test command 'EB_PR=13419 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_13419 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17769

Test results coming soon (I hope)...

Details

- notification for comment with ID 879769060 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 14, 2021

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
generoso-c1-s-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/89602577fe679ea4acad4e0642b3bb90 for a full test report.

Micket
Micket previously requested changes Jul 14, 2021
View reviewed changes
Comment thread easybuild/easyconfigs/b/Bio-SearchIO-hmmer/Bio-SearchIO-hmmer-1.7.3-GCC-10.2.0.eb Outdated
@Micket
Copy link
Copy Markdown
Contributor

Micket commented Jul 14, 2021

Test report by @Micket
SUCCESS
Build succeeded for 8 out of 8 (2 easyconfigs in total)
alvis-c1 - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/cfe491fbeaa54bb46435b909d5d86c57 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jul 16, 2021

Test report by @smoors
SUCCESS
Build succeeded for 6 out of 6 (2 easyconfigs in total)
node366.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 2.7.5
See https://gist.github.com/c212169745594412a754b6f86222ffd3 for a full test report.

smoors
smoors approved these changes Jul 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors added the bug fix label Jul 16, 2021
@smoors smoors dismissed Micket’s stale review July 16, 2021 08:59

changes done

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jul 16, 2021

Going in, thanks @hajgato!

@smoors smoors merged commit e12e3a4 into easybuilders:develop Jul 16, 2021
@boegel boegel changed the title prokka needs Bio-Search-hmmer, but it is not part of BioPerl>1.7.3 add missing Bio-Search-hmmer dependency for prokka Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

@Micket Micket Micket left review comments

Assignees

No one assigned

Labels

bug fix new

Projects

None yet

Milestone

4.4.2

Development

Successfully merging this pull request may close these issues.

4 participants

@hajgato @Micket @boegelbot @smoors