avoid downloading old numpy version during install for h5py#13428
avoid downloading old numpy version during install for h5py#13428smoors merged 14 commits intoeasybuilders:developfrom
Conversation
By default h5py's setup.py has a setup_requires for the minimum supported version of numpy (older then the one in SciPy-bundle, in some cases) based on the python interpretor version, resulting in pip attempting to fetch it during the install phase. As the dependency is already managed through easy_build, and h5py's install_requires is for any version newer than the minimum version, this change suppresses the setup_requires (using the mechanism provided by h2py for "downstream packgers - e.g. Linux distros").
By default h5py's setup.py has a setup_requires for the minimum supported version of numpy (older then the one in SciPy-bundle, in some cases) based on the python interpretor version, resulting in pip attempting to fetch it during the install phase. As the dependency is already managed through easy_build, and h5py's install_requires is for any version newer than the minimum version, this change suppresses the setup_requires (using the mechanism provided by h2py for "downstream packgers - e.g. Linux distros").
By default h5py's setup.py has a setup_requires for the minimum supported version of numpy (older then the one in SciPy-bundle, in some cases) based on the python interpretor version, resulting in pip attempting to fetch it during the install phase. As the dependency is already managed through easy_build, and h5py's install_requires is for any version newer than the minimum version, this change suppresses the setup_requires (using the mechanism provided by h2py for "downstream packgers - e.g. Linux distros").
By default h5py's setup.py has a setup_requires for the minimum supported version of numpy (older then the one in SciPy-bundle, in some cases) based on the python interpretor version, resulting in pip attempting to fetch it during the install phase. As the dependency is already managed through easy_build, and h5py's install_requires is for any version newer than the minimum version, this change suppresses the setup_requires (using the mechanism provided by h2py for "downstream packgers - e.g. Linux distros").
Micket
left a comment
There was a problem hiding this comment.
Maybe add a short comment that explains what it does?
Also, are only the 2020b versions affected?
Sure, I initially put one in then removed it as I didn't think it was the done thing to comment in .eb files 😉 I'll put one back.
No but the environment variable to selectively disable the |
By default h5py's setup.py has a setup_requires for the minimum supported version of numpy (older then the one in SciPy-bundle, in some cases) based on the python interpretor version, resulting in pip attempting to fetch it during the install phase. As the dependency is already managed through easy_build, and h5py's install_requires is for any version newer than the minimum version, this change suppresses the setup_requires (using the mechanism provided by h2py for "downstream packgers - e.g. Linux distros").
|
@boegelbot: please test @ generoso |
|
@smoors: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 880956725 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
Test report by @smoors |
|
Test report by @Micket |
|
Test report by @smoors |
|
Going in, thanks @LHurst-JM! |
By default h5py's setup.py has a setup_requires for exactly the minimum supported version of numpy (older then the one in SciPy-bundle, in some cases) based on the python interpretor version, resulting in pip attempting to fetch it during the EasyBuild install phase.
As the dependency is already managed through easy_build, and h5py's install_requires is for any version newer than the minimum version, this change suppresses the setup_requires (using the mechanism provided by h2py for "downstream packagers - e.g. Linux distros").
Resolves #13424