Skip to content

fix order of components in recent GTK+ easyconfigs to avoid dependency on system GTK+ in GTK+ themes#13449

Merged
lexming merged 1 commit intoeasybuilders:developfrom
Flamefire:20210716154558_new_pr_GTK+32413
Jul 16, 2021
Merged

fix order of components in recent GTK+ easyconfigs to avoid dependency on system GTK+ in GTK+ themes#13449
lexming merged 1 commit intoeasybuilders:developfrom
Flamefire:20210716154558_new_pr_GTK+32413

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Jul 16, 2021

(created using eb --new-pr)

The adawaita-theme requires GTK+ and will e.g. search for gtk-encode-symbolic-svg and use it if found which will make the installation fail if a system GTK+ is installed.
As there is no option to disable this I moved GTK+ before the themes (as it is correct) and patched out the search for gtk-encode-symbolic-svg

@Flamefire Flamefire force-pushed the 20210716154558_new_pr_GTK+32413 branch 3 times, most recently from e336058 to 5c90fc5 Compare July 16, 2021 13:52
@Flamefire Flamefire force-pushed the 20210716154558_new_pr_GTK+32413 branch from 5c90fc5 to ffe8e37 Compare July 16, 2021 13:54
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Jul 16, 2021

Test report by @lexming
SUCCESS
Build succeeded for 18 out of 18 (4 easyconfigs in total)
node355.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/aa18867609c083b564b73333a0bdfb8d for a full test report.

@Flamefire
Copy link
Copy Markdown
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 69 out of 69 (4 easyconfigs in total)
taurusi5404.taurus.hrsk.tu-dresden.de - Linux RHEL 7.9, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/683f94d694c200a05435356ab7235de2 for a full test report.

Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming lexming added this to the next release (4.4.2?) milestone Jul 16, 2021
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Jul 16, 2021

Going in, thanks @Flamefire !

@lexming lexming merged commit ae36adc into easybuilders:develop Jul 16, 2021
@Flamefire Flamefire deleted the 20210716154558_new_pr_GTK+32413 branch July 19, 2021 07:02
@boegel boegel changed the title Avoid dependency on system GTK+ in GTK+ themes fix order of components in recent GTK+ easyconfigs to avoid dependency on system GTK+ in GTK+ themes Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants