Skip to content

add hal9001 extension to recent R v4.x easyconfigs#13451

Merged
branfosj merged 3 commits intoeasybuilders:developfrom
hajgato:R-hal9001
Jul 30, 2021
Merged

add hal9001 extension to recent R v4.x easyconfigs#13451
branfosj merged 3 commits intoeasybuilders:developfrom
hajgato:R-hal9001

Conversation

@hajgato
Copy link
Copy Markdown
Collaborator

@hajgato hajgato commented Jul 16, 2021

No description provided.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jul 20, 2021

@hajgato I think it makes sense to wait until my similar recent PR has been merged #13448 ?

@hajgato
Copy link
Copy Markdown
Collaborator Author

hajgato commented Jul 23, 2021

@verdurin I have time....

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jul 26, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 26, 2021

@verdurin: Request for testing this PR well received on generoso

PR test command 'EB_PR=13451 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_13451 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17832

Test results coming soon (I hope)...

Details

- notification for comment with ID 886808293 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Jul 27, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/52b58223fd63bbc4b1604f3aac0a2aa7 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Jul 28, 2021

Test report by @branfosj
FAILED
Build succeeded for 11 out of 12 (9 easyconfigs in total)
bear-pg0212u15b.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) CPU E5-2640 v4 @ 2.40GHz (broadwell), Python 3.6.8
See https://gist.github.com/2f1efb0b875ad530b116296ee4d8280d for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Jul 29, 2021

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0212u15b.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) CPU E5-2640 v4 @ 2.40GHz (broadwell), Python 3.6.8
See https://gist.github.com/cbb895f639dfb5a985eb4d993988b84d for a full test report.

@branfosj branfosj added this to the 4.x milestone Jul 29, 2021
branfosj
branfosj approved these changes Jul 29, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj branfosj modified the milestones: 4.x, next release (4.4.2?) Jul 30, 2021
@branfosj
Copy link
Copy Markdown
Member

branfosj commented Jul 30, 2021

Going in, thanks @hajgato!

@branfosj branfosj merged commit 85ec60d into easybuilders:develop Jul 30, 2021
@boegel boegel changed the title Add hal9001 module to R v4 add hal9001 extension to recent R v4.x easyconfigs Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@branfosj branfosj branfosj approved these changes

Assignees

No one assigned

Labels

code cleanup enhancement

Projects

None yet

Milestone

4.4.2

Development

Successfully merging this pull request may close these issues.

4 participants

@hajgato @verdurin @boegelbot @branfosj